This is to make room for a new "/judging" endpoint to capture the
notification that a player is in the process of performing judging,
(that they've started clicking on some of the words in the list).
This commit also fixes the test suite to track this change.
Note: "judged" isn't really a perfect name here. By analogy with
"answer" what we want here is a noun, which would imply "judgment" but
that suggests an entirely different meaning to my ears. So, for now,
we're going with the slightly inconsistent "judged".
this.broadcast_event_object('ambiguities', this.state.ambiguities);
}
this.broadcast_event_object('ambiguities', this.state.ambiguities);
}
- receive_judging(prompt_id, session_id, word_groups) {
+ receive_judged(prompt_id, session_id, word_groups) {
const player = this.players_by_session[session_id];
if (! player)
return { valid: false, message: "Player not found" };
const player = this.players_by_session[session_id];
if (! player)
return { valid: false, message: "Player not found" };
game.perform_judging();
});
game.perform_judging();
});
-router.post('/judging/:prompt_id([0-9]+)', (request, response) => {
+router.post('/judged/:prompt_id([0-9]+)', (request, response) => {
const game = request.game;
const prompt_id = parseInt(request.params.prompt_id, 10);
const game = request.game;
const prompt_id = parseInt(request.params.prompt_id, 10);
- const result = game.receive_judging(prompt_id,
- request.session.id,
- request.body.word_groups);
+ const result = game.receive_judged(prompt_id,
+ request.session.id,
+ request.body.word_groups);
response.json(result);
});
response.json(result);
});
test "$result" = '"Grains of Sand" "people" "sand" "sands" "sun" "SunLight" "SunShine" "towels" "wafer" "water"'
TEST_END
test "$result" = '"Grains of Sand" "people" "sand" "sands" "sun" "SunLight" "SunShine" "towels" "wafer" "water"'
TEST_END
- curl_post $empathy_game_path/judging/$2 "{ \"word_groups\": $3}" "-b $1"
+ curl_post $empathy_game_path/judged/$2 "{ \"word_groups\": $3}" "-b $1"
}
TEST "Submit word groups from alice"
}
TEST "Submit word groups from alice"
-result=$(empathy_judging $alice $prompt_id '[["sun","SunLight","SunShine"],["sand","sands","Grains of Sand"],["water","wafer"]]')
+result=$(empathy_judged $alice $prompt_id '[["sun","SunLight","SunShine"],["sand","sands","Grains of Sand"],["water","wafer"]]')
test "$result" = '{"valid":true}'
TEST_END
TEST "Submit word groups from bob"
test "$result" = '{"valid":true}'
TEST_END
TEST "Submit word groups from bob"
-result=$(empathy_judging $bob $prompt_id '[["sands","grains of sand"],["water","wafer"]]')
+result=$(empathy_judged $bob $prompt_id '[["sands","grains of sand"],["water","wafer"]]')
test "$result" = '{"valid":true}'
TEST_END
TEST "Submit word groups from charlie"
test "$result" = '{"valid":true}'
TEST_END
TEST "Submit word groups from charlie"
-result=$(empathy_judging $charlie $prompt_id '[["SunLight","SunShine"],["sand","Grains of Sand"]]')
+result=$(empathy_judged $charlie $prompt_id '[["SunLight","SunShine"],["sand","Grains of Sand"]]')
test "$result" = '{"valid":true}'
TEST_END
test "$result" = '{"valid":true}'
TEST_END