1 2005-12-14 Carl Worth <cworth@cworth.org>
3 * src/ttt-server.h: Update the documentation of these functions to
4 be more precise about what happens to client mutexes.
6 * src/ttt-board.c: (ttt_board_is_won): And some white space to
7 make things more readable.
9 2005-12-13 Bryan Worth <bryan@theworths.org>
10 * src/ttt-curses-client: Cleaned up text-entry code. Added support
11 for HOME, END, DELETE, and ARROW keys
14 2005-12-13 Carl Worth <cworth@cworth.org>
16 * TODO: Note that ttt-server should retry a couple times if its
17 port is not available.
19 * src/test-board.c: (main): Remove debug print messages.
21 * src/ttt-board.c: (ttt_board_make_move): Tighten up the code just
24 2005-12-10 Richard D. Worth <richard@theworths.org>
26 * TODO: check off INVITE, RETRACT, DECLINE, Game Invitation
27 notices, Connection setup errors, NO_INVITE, User information
30 * src/ttt-client.c: (_ttt_client_execute_helo),
31 (_ttt_client_execute_statistics), (_ttt_client_execute_message),
32 (_ttt_client_execute_help), (_ttt_client_execute_version),
33 (_ttt_client_execute_quit), (_ttt_client_execute_invite),
34 (_ttt_client_execute_accept), (_ttt_client_execute_retract),
35 (_ttt_client_execute_decline), (_read_request),
37 (_handle_requests_thread): Whitespace changes. Use exported get
38 methods (get_username, get_num_wins). Use strcasecmp in place of
39 toupper. Finish RETRACT, DECLINE.
43 * src/ttt-server.c: (ttt_server_init),
44 (ttt_server_register_client), (ttt_server_unregister_client),
45 (ttt_server_verify_username),
46 (ttt_server_get_client_from_username), (ttt_server_add_invite),
47 (ttt_server_remove_invite): Add invite struct. Make username case
48 insensitive (missed in register_client). Implement add_invite,
49 remove_invite. Moved statistics to ttt-client.c
51 2005-12-09 Carl Worth <cworth@cworth.org>
53 * src/ttt-server.c (ttt_server_unregister_client): Move client has
54 left message to stderr so it makes it to the log file too.
56 2005-12-09 Carl Worth <cworth@cworth.org>
58 * src/ttt-server.c (main): Put the initial server started message
59 in the log file as well.
61 2005-12-09 Carl Worth <cworth@cworth.org>
64 * src/ttt-args.c: (ttt_args_help), (ttt_args_parse): Add a -u,
65 --user option for controlling the uid under which the server
69 * src/ttt-server.c: (ttt_server_register_client), (main): Recert
70 the dup of stdout which wasn't working. Instead just print client
71 join information on stderr so that it goes into the log. Implement
72 support for the user option by calling setuid to drop root
73 privileges the process might start out with.
75 2005-12-09 Bryan Worth <bryan@theworths.org>
76 * src/ttt-curses-client.c: added error checking to ttt_create_client
77 call. Added ability to escape server commands by prepending with "/".
78 Added ability so override port number with port=xxxx entry in
81 2005-12-08 Carl Worth <cworth@cworth.org>
83 * src/ttt-server.c (main): When detached dup stdout to stderr so
84 that everything appears in the log file.
86 2005-12-08 Carl Worth <cworth@cworth.org>
89 * src/ttt-args.c: (ttt_args_help), (ttt_args_parse): Add
90 -d,--detach and --pid-file=FILE options for running the server as
93 * src/ttt-server.c: (ttt_server_statistics),
94 (ttt_server_verify_username), (_detach_and_write_child_pid_to),
95 (main): Add support for detaching and writing out the child PID to
99 * src/x.c: (xfopen), (xdup2): Two new x-functions.
101 2005-12-08 Carl Worth <cworth@cworth.org>
103 * src/ttt-args.c: (ttt_args_help), (ttt_args_parse):
105 * src/ttt-server.c: (ttt_server_statistics),
106 (ttt_server_verify_username), (_detach_and_write_child_pid_to),
108 * src/x.c: (xfopen), (xdup2):
111 2005-12-08 Bryan Worth <bryan@theworths.org>
112 * src/ttt-curses-client.c: Multiple improvements!
113 Username taken from USER environment variable and stored as
114 preference in ~/.ttt/client.conf (username=xxxxxx). Backspace
115 should now work correctly with all term types. Status messages
116 display in seperate area. "MESSAGE" reply from server is
117 suppressed. Eliminated most global variables.
120 2005-12-08 Carl Worth <cworth@cworth.org>
122 * src/Makefile.am: Fix rule to auto-generate ttt-lex.h.
124 * src/ttt-lex.h: Remove generated file from revision control.
126 * src/ttt-lex.l: Add copyright/license blurb.
129 * src/ttt-client.c: (yy_init_globals), (use_yy_init_globals):
130 Shut off some annoying compiler warnings due to flex bugs (only
133 2005-12-07 Richard D. Worth <richard@theworths.org>
135 * PROTOCOL: Remove unused error NOT_IN_GAME. Add error
138 * TODO: Add error NOT_VALID_MOVE.
141 * src/ttt-error.c: (ttt_error_string): Add section comments. Add
142 error NOT_VALID_MOVE.
144 2005-12-06 Bryan Worth <bryan@theworths.org>
145 * src/ttt-error.c: fixed missing errors (NO_INVITE, NO_GAME)
147 2005-12-06 Richard D. Worth <richard@theworths.org>
149 * PROTOCOL: Add error NO_INVITE
151 * TODO: Uncheck INVITE, ACCEPT
153 * src/ttt-error.c: (ttt_error_string): Add errors NO_INVITE,
156 * src/ttt-client.c: (_ttt_client_execute_message),
157 (_ttt_client_execute_help), (_ttt_client_execute_version),
158 (_ttt_client_execute_invite), (_ttt_client_execute_accept),
159 (_ttt_client_execute_retract), (_ttt_client_execute_decline):
160 Whitespace changes. Partially implement RETRACT, DECLINE.
162 2005-12-05 Richard D. Worth <richard@theworths.org>
164 * PROTOCOL: Fill some missing possible error occurrences.
166 * TODO: Check off INVITE, ACCEPT, ERROR COMMAND, ERROR NO_USER
169 * src/ttt-server.c: (ttt_server_verify_username):
170 * src/ttt-client.c: (_ttt_client_execute_help),
171 (_ttt_client_execute_invite), (_ttt_client_execute_accept):
172 Implement INVITE, ACCEPT
174 2005-12-05 Richard D. Worth <richard@theworths.org>
176 * src/ttt-curses-client.c: (mvprintstr), (mvwprintstr), (wprint),
177 (main), (finish): Whitespace changes.
179 2005-12-04 Bryan Worth <bryan@theworths.org>
180 * src/ttt-socket.c: (ttt_socket_create_client) fixed socket to be
181 non-blocking. (ttt_socket_read) added return value for number
183 * Makefile.am: added necessary code for new curses-client program.
184 * src/ttt-curses-client: new ncurses based client
186 2005-12-03 Richard D. Worth <richard@theworths.org>
188 * PROTOCOL: Add RETRACT, DECLINE. Add game identifier for all game
191 * TODO: Add RETRACT, DECLINE, notices.
193 2005-12-03 Richard D. Worth <richard@theworths.org>
195 * PROTOCOL: Add underscores to error codes. Add STATISTICS
196 command. Remove statistics from WHO.
198 * TODO: Add STATISTICS. Check off STATISTICS.
200 * src/ttt.h: Define TTT_SERVER_PROTOCOL_VERSION for VERSION.
202 * src/ttt-error.c: (ttt_error_string): Add underscores to error
206 * src/ttt-client.c: (_ttt_client_execute_helo),
207 (_ttt_client_execute_statistics), (_ttt_client_execute_message),
208 (_ttt_client_execute_version), (_ttt_client_execute_quit),
209 (_ttt_client_init), (_ttt_client_fini), (ttt_client_get_username),
210 (ttt_client_set_username): Rename client->name to
211 client->username. Implement STATISTICS. Complete implementation of
215 * src/ttt-server.c: (ttt_server_register_client),
216 (ttt_server_unregister_client), (ttt_server_who),
217 (ttt_server_statistics): Track rename of client->name to
218 client->username. Add server helper for STATISTICS.
220 2005-12-02 Richard D. Worth <richard@theworths.org>
222 * TODO: Check off Global commands, HELP, VERSION.
224 * src/ttt-client.c: (_ttt_client_execute_message),
225 (_ttt_client_execute_help), (_execute_request): Whitespace
226 changes. Implement HELP with usage and short description.
228 * src/ttt-server.c: Update the server welcome message.
230 2005-12-01 Richard D. Worth <richard@theworths.org>
232 * TODO: Check off NOTICE MESSAGE, ERROR NONAMESET.
234 * PROTOCOL: Add NONAMESET error in possible errors where
235 applicable. Add description for MESSAGE.
237 * src/ttt-token.h: Add token typedef. Rename token type enum.
239 * src/ttt-lex.l: Add support for quoted string as single token.
240 * src/ttt-lex.h: Autogenerated.
242 * src/ttt-client.c: (_ttt_client_execute_helo),
243 (_ttt_client_execute_who), (_ttt_client_execute_message),
244 (_ttt_client_execute_help), (_ttt_client_execute_version),
245 (_ttt_client_execute_quit), (_ttt_client_init), (_read_request),
246 (_execute_request): Whitespace changes. Implement VERSION,
247 HELP. Change args_required back to args_min and args_max (see
248 PROTOCOL\HELP). Modify MESSAGE to accept one token arg and quote
249 output. Return NONAMESET error where applicable.
251 2005-11-29 Carl Worth <cworth@cworth.org>
254 * src/ttt-socket.c: (ttt_socket_create_client): New function for
255 creating a client socket.
258 * src/x.c: (xconnect): Add xconnect. Return a couple of useful
259 error status values so that callers can recover on connection
260 refused or host unreachable.
262 * src/ttt.h: Add TTT_STATUS_CONNECTION_REFUSED and
263 TTT_STATUS_NETWORK_UNREACHABLE.
265 2005-11-28 Kevin Worth <kevin@theworths.org>
267 * PROTOCOL: Changed board cell numbering to start with zero
271 * src/test-board.c: (main): Added new file for testing.
273 * src/ttt-board.c: (ttt_board_init), (ttt_board_to_string):
274 * src/ttt-board.h: Implemented board_to_string.
276 2005-11-28 kevin worth <kevin@theworths.org>
279 * src/ttt-board.h: Moved struct def from ttt-board.h into
280 ttt-board.c to make it private
285 2005-11-28 Carl Worth <cworth@cworth.org>
287 * TODO: Add instructions on using the first letter of our names to
288 indicate we are working on something.
290 2005-11-25 Bryan Worth <bryan@theworths.org>
291 * ttt-client.c, ttt-server.c, ttt-error.c changed line breaks to
292 <crlf> (\r\n) for network compatibility
294 2005-11-25 Bryan Worth <bryan@theworths.org>
295 * TODO: checked off NOTICE USER and NOTICE QUIT
296 *src/ttt-client.c: (_ttt_client_execute_helo): implement NOTICE USER
297 *(_ttt_client_execute_quit): implement NOTICE QUIT
299 2005-11-25 Bryan Worth <bryan@theworths.org>
300 * TODO: checked off MESSAGE
302 *src/ttt-client.c: (_ttt_client_execute_message): Implement MESSAGE
303 *(_execute_request): changed arg_required to behave as a minimum
304 instead of an absolute number to allow optional arguments such as
307 2005-11-25 Richard D. Worth <richard@theworths.org>
309 * TODO: checked off WHO, QUIT, ERROR SYNTAX
311 * src/ttt-client.c: (_ttt_client_execute_helo), (_ttt_client_init),
312 (ttt_client_get_num_wins):
314 * src/ttt-server.c: (ttt_server_who): Whitespace changes. Add
315 missing player win count for WHO.
317 2005-11-24 Richard D. Worth <richard@theworths.org>
319 * AUTHORS: Add Richard D. Worth
320 * TODO: Add newline before EOF
322 * src/ttt-client.c: (_ttt_client_execute_who):
324 * src/ttt-server.c: (ttt_server_who): Implement WHO.
326 2005-11-24 Carl Worth <cworth@cworth.org>
328 * PROTOCOL: Document QUIT.
330 * src/ttt-client.c: (_ttt_client_execute_helo),
331 (_ttt_client_execute_quit), (_ttt_client_init), (_ttt_client_fini),
332 (_execute_request), (_handle_requests_thread): Implement QUIT. Add
333 client->registered flag and unregister only if registered. Change
334 from args_min and args_max to args_required.
337 * src/ttt-error.c: (ttt_error_string):
338 * src/ttt-server.c: (ttt_server_register_client): Put underscores
339 in TTT_ERRROR names for better readability.
341 2005-11-24 Carl Worth <cworth@cworth.org>
344 * src/ttt-server.c: (ttt_server_init),
345 (ttt_server_register_client): Remove unique-name generation from
346 the server. The client is going to have to have code to do this
349 * src/ttt-client.c: Change minimum arguments for HELO from 0 to 1.
351 * TODO: Note that HELO and ERROR INVALIDNAME are implemented in
354 2005-11-23 Richard D. Worth <richard@theworths.org>
356 * PROTOCOL: Remove unused servername
358 * src/ttt-client.h: * src/ttt-client.c:
359 (_ttt_client_execute_helo), (_ttt_client_init),
360 (_ttt_client_fini), (_execute_request), (ttt_client_get_name),
361 (ttt_client_set_name): Added command descriptions structure. Match
362 command case-insensitively, dispatch to execute
363 function. Implement HELO command. Register on HELO instead of on
366 * src/ttt-server.h: * src/ttt-server.c: (ttt_server_init),
367 (ttt_server_register_client), (ttt_server_unregister_client),
368 (ttt_server_get_host), (ttt_server_get_port), (main): Added host
369 and port to server. Make client registration name-based rather
372 * src/x.c: (xstrdup): Return NULL on NULL
374 * src/ttt-lex.h: Regenerated
376 2005-11-22 Carl Worth <cworth@cworth.org>
378 * TODO: Add TODO file listing all the stuff from the protocol that
379 needs to be implemented.
386 * src/ttt-token.h: Add support for a flex-based tokenizer which
387 tokenizes newlines and space-separated strings.
389 * src/ttt-client.c: (_ttt_client_init), (_ttt_client_fini),
390 (_append_to_request), (_free_request), (_read_request),
391 (_execute_request): Use new tokenizer to tokenize input into an
392 array of request strings.
394 2005-11-15 Carl Worth <cworth@cworth.org>
398 * src/ttt-error.c: (ttt_error_string): Add error values and error
399 strings from protocol.
401 * src/ttt.h: Add typedefs for ttt_client_t and ttt_server_t so
402 that there's no problem with ttt-client.h and ttt-server.h needing
403 to mutually include each other.
406 * src/ttt-server.c: (ttt_server_register_client),
407 (ttt_server_unregister_client), (_ttt_server_accept), (main): Push
408 the client request handling thread back down into ttt-client.c
409 where it really does belong. The server code no longer ever
410 reaches down inside the ttt_client_t structure. Export
411 ttt_server_register_client and ttt_server_unregister_client. Add
412 documentation for ttt_server_broadcast. Document locking semantics
413 for all functions which acquire the server lock.
416 * src/ttt-client.c: (_ttt_client_create), (_ttt_client_destroy),
417 (_read_into_request_until), (_read_request), (_execute_request),
418 (_handle_requests_thread), (ttt_client_new), (ttt_client_get_id):
419 Pull the ttt_client structure definition back down inside the
420 ttt-client.c file. Don't export ttt_client_create and
421 ttt_client_destroy anymore, but instead just use static
422 _ttt_client_init and _ttt_client_fini. Implement the broadcast by
423 just passing a client pointer around and using client->request
424 rather than passing char *request all over. Document new
425 ttt_client_new and remove ttt_client_read_line. Add locking to
426 ttt_client_send and document it. Add ttt_client_get_id.
428 2005-11-14 Carl Worth <cworth@cworth.org>
430 Server now acts as a very simple chat server.
433 * src/ttt-client.c: (ttt_client_create), (ttt_client_destroy),
434 (_append_to_request), (ttt_client_read_into_request_until),
435 (ttt_client_read_line), (ttt_client_send): Add support to do a
436 buffering read within the client and to reuse the buffer (which
437 grows by doubling) from one request to the next. Add function to
438 send a message to a client.
440 * src/ttt-server.c: (ttt_server_init), (ttt_server_create_client):
441 Add support for a client idea. Resize the server's client list by
443 * src/ttt-server.c: (ttt_server_destroy_client): Add support to
445 * src/ttt-server.c: (_handle_client_requests_thread),
446 (_accept_client): Move handling of client requests up to
447 ttt-server.c from ttt-client.c. Use threads rather than a fork per
450 * src/ttt-server.h: (ttt_server_broadcast): Add function to send a
451 message to all connected clients.
454 * src/ttt-socket.c: (ttt_socket_read),
455 (ttt_socket_write): Add functions to do blocking read or write of
456 the specified number of bytes.
458 * src/ttt-socket.c: (ttt_socket_accept): Remove fork, so that the
459 accept function call can take care of anything like that itself.
462 * src/x.c: (xread), (xwrite): New wrappers for read and write.
464 * src/ttt.h: Add TTT_STATUS_EOF, TRUE, and FALSE.
466 * src/ttt.c: Need to include ttt-args.h explicitly now.
468 2005-11-11 Carl Worth <cworth@cworth.org>
471 * src/ttt-server.c: (ttt_server_init), (ttt_server_add_client),
472 (_accept_client), (main): Add a new ttt_server_t object with a
473 mutex-protected list of clients. Move client handling code down
474 into new ttt-client.c.
477 * src/ttt-client.c: (ttt_client_create), (ttt_client_destroy),
478 (ttt_client_handle_requests): New ttt_client_t object that simply
479 holds a pointer back to the server as well as the client socket
483 * src/ttt-socket.c: (ttt_socket_accept): Add closure argument. Add
484 a call to fork before calling the accept callback.
486 * src/ttt-args.c: Hide unused ttt_args_usage from the compiler to
487 keep it from complaining.
489 * src/ttt.c: (main): Rename the client main program from
490 ttt-client to ttt.c, (since the server code now has its own
494 * src/Makefile.am: Include and link with pthread now that we have
495 pthread-based mutex locking.
497 2005-11-11 Carl Worth <cworth@pippin.local>
499 * src/ttt-server.c: (main): Don't assign to stderr which is
500 apparently an invalid lvalue on Mac OS X.
503 * src/x.c: (xfreopen): Change return type to void.
505 * src/ttt-board.c: (ttt_board_to_string): Add missing return
508 2005-11-11 Carl Worth <cworth@cworth.org>
510 * configure.in: Key off of src/ttt.h instead of src/ttt.c which no
513 2005-11-11 Carl Worth <cworth@cworth.org>
517 * src/x.h: Move include of stdarg.h from x.c to ttt.h.
519 2005-11-11 Carl Worth <cworth@cworth.org>
521 * src/ttt-board.h: Include ttt.h to get standard includes.
523 * src/ttt-socket.c: Replace include of netinet/ip.h with
524 netinet/in.h which seems to be necessary for BSD libc, (eg. Mac OS
527 2005-11-09 Carl Worth <cworth@cworth.org>
531 * src/ttt-server.c: (ttt_dispatch), (main):
533 * src/ttt-socket.c: (_sockaddr_init), (_wait_for_connection),
534 (ttt_socket_create_server), (ttt_socket_accept): Push a lot of
535 code out of ttt-server.c down into a new ttt_socket abstraction
536 layer. The code is much easier to read now. The server also no
537 longer exits when the first client exits, but continues to listen
538 for more connections.
540 2005-11-09 Carl Worth <cworth@cworth.org>
543 * src/ttt-args.c: (ttt_args_help), (ttt_args_parse): Add support
544 for -h,--host, -p,--port, and --log-file command-line arguments.
546 * src/ttt-server.c: (main): Use host, port, and log-file
547 command-line arguments.
549 * src/ttt-client.c: (main): Track change in signature of
553 * src/x.c: (xfdopen), (xfreopen): More wrappers.
555 2005-11-08 Carl Worth <cworth@cworth.org>
558 * src/ttt-server.c: (_sockaddr_init), (_wait_for_connection),
559 (main): Add socket, bind, listen, accept calls to provide a
560 simple, functional, one-shot server demonstration.
563 * src/x.c: (xsocket), (xbind), (xlisten), (xfcntl), (xselect): Add
564 more wrapped system calls.
566 2005-11-07 Carl Worth <cworth@cworth.org>
568 * src/ttt.h: Grab some useful definitions from wdo.h:
569 ASSERT_NOT_REACHEED and TTT_PRINTF_FORMAT. Add several needed
572 * src/Makefile.am: Rip out not-yet existing ttt-command and
575 * src/ttt-args.c: (ttt_args_parse): Track name change from
576 args_help to ttt_args_help.
578 * src/ttt.c: Remove in favor of ttt-server.c and ttt-client.c.
580 * src/x.h: Add prototype for xfwrite.
582 2005-11-05 Richard D. Worth <richard@theworths.org>
584 * src/ttt-board.c: (ttt_board_init): Added for loop counter init.
585 * src/ttt-board.h: Added prototypes.
587 2005-11-05 Richard D. Worth <richard@theworths.org>
589 * src/args.c: Renamed ttt-args.c
590 * src/args.h: Renamed ttt-args.h
591 * src/ttt-args.c: (ttt_args_help), (ttt_args_usage),
592 (ttt_args_parse): Added ttt_ prefix.
593 * src/ttt-args.h: Added ttt_, TTT_ prefix.
595 2005-11-05 Kevin Worth <kevin@cworth.org>
597 * src/ttt-board.c: (ttt_board_init): Implemented board_init.
598 * src/ttt-board.h: (ttt_board_t): Added cells array.
600 2005-11-05 Carl Worth <cworth@cworth.org>
602 * src/Makefile.am: Add ttt-board.[ch] and x.[ch]
605 * src/ttt-board.c: (ttt_board_init), (ttt_board_init_from_string),
606 (ttt_board_to_string), (ttt_board_write): Add some stub functions
607 for Richard and Kevin to have some practice
608 implementing. Functions to represent a board and to go to/from a
612 * src/x.c: (xasprintf), (xvasprintf), (xpipe), (xfork), (xmalloc),
613 (xcalloc), (xrealloc), (xfdopen), (xstrdup), (xfwrite): Several
614 utility functions that make system calls, check the result, and
615 exit on any error. This will simplify the error checking needed in
616 programs using these functions.
618 2005-11-05 Carl Worth <cworth@cworth.org>
620 * src/Makefile.am: Break things up for separate ttt-client and
621 ttt-server and programs.