Set binary mode when outputing PNM from glretrace via stdout.

[apitrace] / cli / cli_diff_images.cpp

diff --git a/cli/cli_diff_images.cpp b/cli/cli_diff_images.cpp
index 3b5507a7cc4202da012f860e563535786466574f..626a34fc7790f4a56fb5070d81f2246c9deb72db 100644 (file)
--- a/cli/cli_diff_images.cpp
+++ b/cli/cli_diff_images.cpp
@@ -30,6 +30,7 @@
 
 #include "cli.hpp"
 #include "os_string.hpp"
+#include "os_process.hpp"
 #include "trace_resource.hpp"
 
 static const char *synopsis = "Identify differences between two image dumps.";
@@ -43,48 +44,42 @@ find_command(void)
 static void
 usage(void)
 {
-    char *args[3];
-
     os::String command = find_command();
+    if (!command.length()) {
+        exit(1);
+    }
 
+    char *args[3];
     args[0] = (char *) command.str();
     args[1] = (char *) "--help";
     args[2] = NULL;
 
-#ifdef _WIN32
-    std::cerr << "The 'apitrace diff-images' command is not yet supported on this O/S.\n";
-#else
-    execv(command.str(), args);
-#endif
-
-    std::cerr << "Error: Failed to execute " << args[0] << "\n";
+    os::execute(args);
 }
 
 static int
 command(int argc, char *argv[])
 {
     int i;
-    char **args = new char* [argc+2];
+    int ret;
 
     os::String command = find_command();
+    if (!command.length()) {
+        return 1;
+    }
 
+    char **args = new char* [argc + 1];
     args[0] = (char *) command.str();
-
-    for (i = 0; i < argc; i++) {
-        args[i+1] = argv[i];
+    for (i = 1; i < argc; i++) {
+        args[i] = argv[i];
     }
+    args[argc] = NULL;
 
-    args[i+1] = NULL;
-
-#ifdef _WIN32
-    std::cerr << "The 'apitrace diff-images' command is not yet supported on this O/S.\n";
-#else
-    execv(command.str(), args);
-#endif
+    ret = os::execute(args);
 
-    std::cerr << "Error: Failed to execute " << args[0] << "\n";
+    delete [] args;
 
-    return 1;
+    return ret;
 }
 
 const Command diff_images_command = {