Remove os::thread_specific_ptr

[apitrace] / common / os_thread.hpp

diff --git a/common/os_thread.hpp b/common/os_thread.hpp
index 9d6a9891524564803d844bfe923de13dfd8442c0..f5f4e48a0f60a3d24131e4828ce9740197d7d1b0 100644 (file)
--- a/common/os_thread.hpp
+++ b/common/os_thread.hpp
@@ -24,9 +24,9 @@
  **************************************************************************/
 
 /*
- * Simple OS abstraction.
+ * OS native thread abstraction.
  *
- * Mimics C++11 / boost threads.
+ * Mimics C++11 threads.
  */
 
 #ifndef _OS_THREAD_HPP_
@@ -39,6 +39,24 @@
 #include <pthread.h>
 #endif
 
+
+/**
+ * Compiler TLS.
+ *
+ * See also:
+ * - http://gcc.gnu.org/onlinedocs/gcc-4.6.3/gcc/Thread_002dLocal.html
+ * - http://msdn.microsoft.com/en-us/library/9w1sdazb.aspx
+ */
+#if defined(_MSC_VER)
+#  define thread_specific __declspec(thread)
+#elif defined(__GNUC__)
+#  define thread_specific __thread
+#else
+#  define thread_specific
+#  error "Unsupported compiler"
+#endif
+
+
 namespace os {
 
 
@@ -187,14 +205,14 @@ namespace os {
     {
     public:
 #ifdef _WIN32
-        /* FIXME */
+        typedef CONDITION_VARIABLE native_handle_type;
 #else
         typedef pthread_cond_t native_handle_type;
 #endif
 
         condition_variable() {
 #ifdef _WIN32
-            /* FIXME */
+            InitializeConditionVariable(&_native_handle);
 #else
             pthread_cond_init(&_native_handle, NULL);
 #endif
@@ -202,7 +220,7 @@ namespace os {
 
         ~condition_variable() {
 #ifdef _WIN32
-            /* FIXME */
+            /* No-op */
 #else
             pthread_cond_destroy(&_native_handle);
 #endif
@@ -211,7 +229,7 @@ namespace os {
         inline void
         signal(void) {
 #ifdef _WIN32
-            /* FIXME */
+            WakeConditionVariable(&_native_handle);
 #else
             pthread_cond_signal(&_native_handle);
 #endif
@@ -219,10 +237,11 @@ namespace os {
 
         inline void
         wait(unique_lock<mutex> & lock) {
+            mutex::native_handle_type & mutex_native_handle = lock.mutex()->native_handle();
 #ifdef _WIN32
-            /* FIXME */
+            SleepConditionVariableCS(&_native_handle, &mutex_native_handle, INFINITE);
 #else
-            pthread_cond_wait(&_native_handle, &lock.mutex()->native_handle());
+            pthread_cond_wait(&_native_handle, &mutex_native_handle);
 #endif
         }
 
@@ -232,97 +251,47 @@ namespace os {
 
 
     /**
-     * Same interface as boost::thread_specific_ptr.
+     * Same interface as std::thread
      */
-    template <typename T>
-    class thread_specific_ptr
-    {
-    private:
-#ifdef _WIN32
-        DWORD dwTlsIndex;
-#else
-        pthread_key_t key;
-
-        static void destructor(void *ptr) {
-            delete static_cast<T *>(ptr);
-        }
-#endif
-
+    class thread {
     public:
-        thread_specific_ptr(void) {
-#ifdef _WIN32
-            dwTlsIndex = TlsAlloc();
-#else
-            pthread_key_create(&key, &destructor);
-#endif
-        }
-
-        ~thread_specific_ptr() {
-#ifdef _WIN32
-            TlsFree(dwTlsIndex);
-#else
-            pthread_key_delete(key);
-#endif
-        }
-
-        T* get(void) const {
-            void *ptr;
 #ifdef _WIN32
-            ptr = TlsGetValue(dwTlsIndex);
+        typedef HANDLE native_handle_type;
 #else
-            ptr = pthread_getspecific(key);
+        typedef pthread_t native_handle_type;
 #endif
-            return static_cast<T*>(ptr);
-        }
 
-        T* operator -> (void) const
+        inline
+        thread() :
+            _native_handle(0)
         {
-            return get();
         }
 
-        T& operator * (void) const
+        inline
+        thread(thread &other) :
+            _native_handle(other._native_handle)
         {
-            return *get();
         }
 
-        void reset(T* new_value=0) {
-            T * old_value = get();
+        template< class Function, class Arg >
+        explicit thread( Function& f, Arg arg ) {
 #ifdef _WIN32
-            TlsSetValue(dwTlsIndex, new_value);
+            DWORD id = 0;
+            _native_handle = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)f, (LPVOID)arg, 0, &id);
 #else
-            pthread_setspecific(key, new_value);
+            pthread_create(&_native_handle, NULL, ( void *(*) (void *))f, arg);
 #endif
-            if (old_value) {
-                delete old_value;
-            }
         }
-    };
-
 
-    /**
-     * Same interface as std::thread
-     */
-    class thread {
-    public:
-#ifdef _WIN32
-        /* FIXME */
-#else
-        typedef pthread_t native_handle_type;
-#endif
-
-        template< class Function, class Arg >
-        explicit thread( Function& f, Arg & arg ) {
-#ifdef _WIN32
-            /* FIXME */
-#else
-            pthread_create(&_native_handle, NULL, f, arg);
-#endif
+        inline bool
+        joinable(void) const {
+            return _native_handle != 0;
         }
 
         inline void
         join() {
 #ifdef _WIN32
-            /* FIXME */
+            WaitForSingleObject(_native_handle, INFINITE);
 #else
             pthread_join(_native_handle, NULL);
 #endif
@@ -330,6 +299,16 @@ namespace os {
 
     private:
         native_handle_type _native_handle;
+
+#if 0
+#ifdef _WIN32
+        template< class Function, class Arg >
+        static DWORD WINAPI
+        ThreadProc(LPVOID lpParameter) {
+
+        );
+#endif
+#endif
     };
 
 } /* namespace os */