Move some checks from TicTacToe.add_move to Game.add_move

[empires-server] / empires.js

diff --git a/empires.js b/empires.js
index 881a2c0dbdd41409bec91c6c1707323a14637e3c..5b9df829e252e9ef42b9ee4d8338007fb1463bc3 100644 (file)
--- a/empires.js
+++ b/empires.js
@@ -38,9 +38,6 @@ class Empires extends Game {
     this.next_player_id = 1;
     this.characters_to_reveal = null;
     this.phase = GamePhase.JOIN;
-
-    /* Send a comment to every connected client every 15 seconds. */
-    setInterval(() => {this.broadcast_string(":");}, 15000);
   }
 
   add_spectator(name, session_id) {
@@ -179,7 +176,14 @@ class Empires extends Game {
     }));
   }
 
-  get players() {
+  /* The base class recently acquired Game.players which works like
+   * Empires.spectators, (and meanwhile the Empires._players
+   * functionality could perhaps be reworked into
+   * Game.players[].team). Until we do that rework, lets use
+   * .registered_players as the getter for the Empires-specific
+   * ._players property to avoid mixing it up with the distinct
+   * Game.players property. */
+  get registered_players() {
     return this._players.map(player => ({id: player.id, name: player.name }));
   }
 
@@ -225,7 +229,7 @@ class Empires extends Game {
     }
 
     if (this._players.length > 0) {
-      const players_json = JSON.stringify(this.players);
+      const players_json = JSON.stringify(this.registered_players);
       const players_data = `event: players\ndata: ${players_json}\n\n`;
       response.write(players_data);
     }
@@ -337,7 +341,7 @@ router.get('/spectators', (request, response) => {
 
 router.get('/players', (request, response) => {
   const game = request.game;
-  response.send(game.players);
+  response.send(game.registered_players);
 });
 
 Empires.meta = {