Fix bug when a player reclaims a previous player object by name

[lmno-server] / game.js

diff --git a/game.js b/game.js
index f9e18cb760725eb9d05a993115bf286f5f0b2e85..fa290681f2fc85117500a0c883683c9fb230ead7 100644 (file)
--- a/game.js
+++ b/game.js
@@ -184,6 +184,7 @@ class Game {
         this.broadcast_event("player-enter", existing.info_json());
       }
       existing.add_connection(connection);
+      this.players_by_session[session.id] = existing;
       return existing;
     }
 
@@ -258,6 +259,10 @@ class Game {
     this.broadcast_event(type, JSON.stringify(obj));
   }
 
+  game_state_json() {
+    return JSON.stringify(this.state, stringify_replacer);
+  }
+
   handle_events(request, response) {
     /* These headers will keep the connection open so we can stream events. */
     const headers = {
@@ -293,8 +298,7 @@ class Game {
     /* Finally, if this game class has a "state" property, stream that
      * current state to the client. */
     if (this.state) {
-      const state_json = JSON.stringify(this.state, stringify_replacer);
-      response.write(`event: game-state\ndata: ${state_json}\n\n`);
+      response.write(`event: game-state\ndata: ${this.game_state_json()}\n\n`);
     }
   }