test: fix test_require_external_prereq()

[notmuch] / test / test-lib.sh

diff --git a/test/test-lib.sh b/test/test-lib.sh
index fe80e89314e201feea3199a2a7c7b443b3b7d2fc..d7282ff66efa6cc237cfe56d20567a170694ffab 100644 (file)
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -554,6 +554,7 @@ test_declare_external_prereq () {
        test "$#" = 2 && name=$2 || name="$binary(1)"
 
        hash $binary 2>/dev/null || eval "
+       test_missing_external_prereq_${binary}_=t
 $binary () {
        echo -n \"\$test_subtest_missing_external_prereqs_\" | grep -e \" $name \" ||
        test_subtest_missing_external_prereqs_=\"$test_subtest_missing_external_prereqs_ $name\"
@@ -561,6 +562,19 @@ $binary () {
 }"
 }
 
+# Explicitly require external prerequisite.  Useful when binary is
+# called indirectly (e.g. from emacs).
+# Returns success if dependency is available, failure otherwise.
+test_require_external_prereq () {
+       binary="$1"
+       if [ "$(eval echo -n \$test_missing_external_prereq_${binary}_)" = t ]; then
+               # dependency is missing, call the replacement function to note it
+               eval "$binary"
+       else
+               true
+       fi
+}
+
 # You are not expected to call test_ok_ and test_failure_ directly, use
 # the text_expect_* functions instead.
 
@@ -880,6 +894,10 @@ EOF
 }
 
 test_emacs () {
+       # test dependencies beforehand to avoid the waiting loop below
+       test_require_external_prereq emacs || return
+       test_require_external_prereq emacsclient || return
+
        if [ -z "$EMACS_SERVER" ]; then
                server_name="notmuch-test-suite-$$"
                # start a detached session with an emacs server