Some initial thoughts on the on-demand loading api.

[apitrace] / trace_file.hpp

diff --git a/trace_file.hpp b/trace_file.hpp
index f0e183d70693912b9feb176e5ecc9c8fb35136ef..fed30a0a8835f64a72c0d61f903279ae3f49b785 100644 (file)
--- a/trace_file.hpp
+++ b/trace_file.hpp
@@ -29,6 +29,7 @@
 
 #include <string>
 #include <fstream>
+#include <stdint.h>
 
 namespace Trace {
 
@@ -38,10 +39,15 @@ public:
         Read,
         Write
     };
-    enum FlushType {
-        FlushShallow,
-        FlushDeep
+    struct Offset {
+        Offset()
+            : chunk(0),
+              offsetInChunk(0)
+        {}
+        uint64_t chunk;
+        uint32_t offsetInChunk;
     };
+
 public:
     static bool isZLibCompressed(const std::string &filename);
     static bool isSnappyCompressed(const std::string &filename);
@@ -59,16 +65,19 @@ public:
     bool write(const void *buffer, int length);
     bool read(void *buffer, int length);
     void close();
-    void flush(FlushType type = FlushShallow);
+    void flush(void);
     int getc();
 
+    virtual bool supportsOffsets() const = 0;
+    virtual File::Offset currentOffset();
+    virtual void setCurrentOffset(const File::Offset &offset);
 protected:
     virtual bool rawOpen(const std::string &filename, File::Mode mode) = 0;
     virtual bool rawWrite(const void *buffer, int length) = 0;
     virtual bool rawRead(void *buffer, int length) = 0;
     virtual int rawGetc() = 0;
     virtual void rawClose() = 0;
-    virtual void rawFlush(FlushType type) = 0;
+    virtual void rawFlush() = 0;
 
 protected:
     std::string m_filename;
@@ -126,9 +135,9 @@ inline void File::close()
     }
 }
 
-inline void File::flush(File::FlushType type)
+inline void File::flush(void)
 {
-    rawFlush(type);
+    rawFlush();
 }
 
 inline int File::getc()
@@ -145,13 +154,15 @@ public:
              File::Mode mode = File::Read);
     virtual ~ZLibFile();
 
+
+    virtual bool supportsOffsets() const;
 protected:
     virtual bool rawOpen(const std::string &filename, File::Mode mode);
     virtual bool rawWrite(const void *buffer, int length);
     virtual bool rawRead(void *buffer, int length);
     virtual int rawGetc();
     virtual void rawClose();
-    virtual void rawFlush(FlushType type);
+    virtual void rawFlush();
 private:
     void *m_gzFile;
 };