X-Git-Url: https://git.cworth.org/git?a=blobdiff_plain;f=retrace%2Fglstate_images.cpp;h=6efc0a677ba24c1e287d776b0a9378cab6c56e61;hb=2ceeef2438ae8dadef64357e385fcbab6059cca6;hp=b95b8cc2411e0f97ed19ad1d5c795588fc10e947;hpb=3941d9f80df99d47579b2619d36b61f8cc7ec3c3;p=apitrace diff --git a/retrace/glstate_images.cpp b/retrace/glstate_images.cpp index b95b8cc..6efc0a6 100644 --- a/retrace/glstate_images.cpp +++ b/retrace/glstate_images.cpp @@ -72,6 +72,7 @@ struct ImageDesc GLint width; GLint height; GLint depth; + GLint samples; GLint internalFormat; inline @@ -79,9 +80,19 @@ struct ImageDesc width(0), height(0), depth(0), + samples(0), internalFormat(GL_NONE) {} + inline bool + operator == (const ImageDesc &other) const { + return width == other.width && + height == other.height && + depth == other.depth && + samples == other.samples && + internalFormat == other.internalFormat; + } + inline bool valid(void) const { return width > 0 && height > 0 && depth > 0; @@ -283,6 +294,8 @@ getActiveTextureLevelDesc(Context &context, GLenum target, GLint level, ImageDes } } + glGetTexLevelParameteriv(target, level, GL_TEXTURE_SAMPLES, &desc.samples); + return desc.valid(); } @@ -379,23 +392,134 @@ getTexImageOES(GLenum target, GLint level, ImageDesc &desc, GLubyte *pixels) } -static inline GLboolean -isDepthFormat(GLenum internalFormat) +struct InternalFormatDesc { - switch (internalFormat) { - case GL_DEPTH_COMPONENT: - case GL_DEPTH_COMPONENT16: - case GL_DEPTH_COMPONENT24: - case GL_DEPTH_COMPONENT32: - case GL_DEPTH_COMPONENT32F: - case GL_DEPTH_COMPONENT32F_NV: - case GL_DEPTH_STENCIL: - case GL_DEPTH24_STENCIL8: - case GL_DEPTH32F_STENCIL8: - case GL_DEPTH32F_STENCIL8_NV: - return GL_TRUE; - } - return GL_FALSE; + GLenum internalFormat; + GLenum format; +}; + + +static const InternalFormatDesc +internalFormatDescs[] = { + + {1, GL_RED}, + {2, GL_RG}, + {3, GL_RGB}, + {4, GL_RGBA}, + + {GL_RED, GL_RED}, + {GL_GREEN, GL_GREEN}, + {GL_BLUE, GL_BLUE}, + {GL_ALPHA, GL_ALPHA}, + {GL_RG, GL_RG}, + {GL_RGB, GL_RGB}, + {GL_BGR, GL_RGB}, + {GL_RGBA, GL_RGBA}, + {GL_BGRA, GL_RGBA}, + {GL_LUMINANCE, GL_LUMINANCE}, + {GL_LUMINANCE_ALPHA, GL_LUMINANCE_ALPHA}, + {GL_INTENSITY, GL_INTENSITY}, + + {GL_RG8, GL_RG}, + {GL_RG16, GL_RG}, + {GL_RGB8, GL_RGB}, + {GL_RGB16, GL_RGB}, + {GL_RGBA8, GL_RGBA}, + {GL_RGBA16, GL_RGBA}, + {GL_RGB10_A2, GL_RGBA}, + {GL_LUMINANCE8, GL_LUMINANCE}, + {GL_LUMINANCE16, GL_LUMINANCE}, + {GL_ALPHA8, GL_ALPHA}, + {GL_ALPHA16, GL_ALPHA}, + {GL_LUMINANCE8_ALPHA8, GL_LUMINANCE_ALPHA}, + {GL_LUMINANCE16_ALPHA16, GL_LUMINANCE_ALPHA}, + {GL_INTENSITY8, GL_INTENSITY}, + {GL_INTENSITY16, GL_INTENSITY}, + + {GL_RED_INTEGER, GL_RED_INTEGER}, + {GL_GREEN_INTEGER, GL_GREEN_INTEGER}, + {GL_BLUE_INTEGER, GL_BLUE_INTEGER}, + {GL_ALPHA_INTEGER, GL_ALPHA_INTEGER}, + {GL_RG_INTEGER, GL_RG_INTEGER}, + {GL_RGB_INTEGER, GL_RGB_INTEGER}, + {GL_BGR_INTEGER, GL_RGB_INTEGER}, + {GL_RGBA_INTEGER, GL_RGBA_INTEGER}, + {GL_BGRA_INTEGER, GL_RGBA_INTEGER}, + {GL_LUMINANCE_INTEGER_EXT, GL_LUMINANCE_INTEGER_EXT}, + {GL_LUMINANCE_ALPHA_INTEGER_EXT, GL_LUMINANCE_ALPHA_INTEGER_EXT}, + + {GL_R8I, GL_RED_INTEGER}, + {GL_R8UI, GL_RED_INTEGER}, + {GL_R16I, GL_RED_INTEGER}, + {GL_R16UI, GL_RED_INTEGER}, + {GL_R32I, GL_RED_INTEGER}, + {GL_R32UI, GL_RED_INTEGER}, + {GL_RG8I, GL_RG_INTEGER}, + {GL_RG8UI, GL_RG_INTEGER}, + {GL_RG16I, GL_RG_INTEGER}, + {GL_RG16UI, GL_RG_INTEGER}, + {GL_RG32I, GL_RG_INTEGER}, + {GL_RG32UI, GL_RG_INTEGER}, + {GL_RGB8I, GL_RGB_INTEGER}, + {GL_RGB8UI, GL_RGB_INTEGER}, + {GL_RGB16I, GL_RGB_INTEGER}, + {GL_RGB16UI, GL_RGB_INTEGER}, + {GL_RGB32I, GL_RGB_INTEGER}, + {GL_RGB32UI, GL_RGB_INTEGER}, + {GL_RGBA8I, GL_RGBA_INTEGER}, + {GL_RGBA8UI, GL_RGBA_INTEGER}, + {GL_RGBA16I, GL_RGBA_INTEGER}, + {GL_RGBA16UI, GL_RGBA_INTEGER}, + {GL_RGBA32I, GL_RGBA_INTEGER}, + {GL_RGBA32UI, GL_RGBA_INTEGER}, + {GL_RGB10_A2UI, GL_RGBA_INTEGER}, + {GL_LUMINANCE8I_EXT, GL_LUMINANCE_INTEGER_EXT}, + {GL_LUMINANCE8UI_EXT, GL_LUMINANCE_INTEGER_EXT}, + {GL_LUMINANCE16I_EXT, GL_LUMINANCE_INTEGER_EXT}, + {GL_LUMINANCE16UI_EXT, GL_LUMINANCE_INTEGER_EXT}, + {GL_LUMINANCE32I_EXT, GL_LUMINANCE_INTEGER_EXT}, + {GL_LUMINANCE32UI_EXT, GL_LUMINANCE_INTEGER_EXT}, + {GL_ALPHA8I_EXT, GL_ALPHA_INTEGER_EXT}, + {GL_ALPHA8UI_EXT, GL_ALPHA_INTEGER_EXT}, + {GL_ALPHA16I_EXT, GL_ALPHA_INTEGER_EXT}, + {GL_ALPHA16UI_EXT, GL_ALPHA_INTEGER_EXT}, + {GL_ALPHA32I_EXT, GL_ALPHA_INTEGER_EXT}, + {GL_ALPHA32UI_EXT, GL_ALPHA_INTEGER_EXT}, + {GL_LUMINANCE_ALPHA8I_EXT, GL_LUMINANCE_ALPHA_INTEGER_EXT}, + {GL_LUMINANCE_ALPHA8UI_EXT, GL_LUMINANCE_ALPHA_INTEGER_EXT}, + {GL_LUMINANCE_ALPHA16I_EXT, GL_LUMINANCE_ALPHA_INTEGER_EXT}, + {GL_LUMINANCE_ALPHA16UI_EXT, GL_LUMINANCE_ALPHA_INTEGER_EXT}, + {GL_LUMINANCE_ALPHA32I_EXT, GL_LUMINANCE_ALPHA_INTEGER_EXT}, + {GL_LUMINANCE_ALPHA32UI_EXT, GL_LUMINANCE_ALPHA_INTEGER_EXT}, + {GL_INTENSITY8I_EXT, GL_RED_INTEGER}, + {GL_INTENSITY8UI_EXT, GL_RED_INTEGER}, + {GL_INTENSITY16I_EXT, GL_RED_INTEGER}, + {GL_INTENSITY16UI_EXT, GL_RED_INTEGER}, + {GL_INTENSITY32I_EXT, GL_RED_INTEGER}, + {GL_INTENSITY32UI_EXT, GL_RED_INTEGER}, + + {GL_DEPTH_COMPONENT, GL_DEPTH_COMPONENT}, + {GL_DEPTH_COMPONENT16, GL_DEPTH_COMPONENT}, + {GL_DEPTH_COMPONENT24, GL_DEPTH_COMPONENT}, + {GL_DEPTH_COMPONENT32, GL_DEPTH_COMPONENT}, + {GL_DEPTH_COMPONENT32F, GL_DEPTH_COMPONENT}, + {GL_DEPTH_COMPONENT32F_NV, GL_DEPTH_COMPONENT}, + {GL_DEPTH_STENCIL, GL_DEPTH_COMPONENT}, + {GL_DEPTH24_STENCIL8, GL_DEPTH_COMPONENT}, + {GL_DEPTH32F_STENCIL8, GL_DEPTH_COMPONENT}, + {GL_DEPTH32F_STENCIL8_NV, GL_DEPTH_COMPONENT}, +}; + + +static GLenum +getFormat(GLenum internalFormat) +{ + for (unsigned i = 0; i < sizeof internalFormatDescs / sizeof internalFormatDescs[0]; ++i) { + if (internalFormatDescs[i].internalFormat == internalFormat) { + return internalFormatDescs[i].format; + } + } + return GL_RGBA; } @@ -415,15 +539,11 @@ dumpActiveTextureLevel(JSONWriter &json, Context &context, GLenum target, GLint json.beginMember(label); - GLuint channels; - GLenum format; - if (!context.ES && isDepthFormat(desc.internalFormat)) { - format = GL_DEPTH_COMPONENT; - channels = 1; - } else { - format = GL_RGBA; - channels = 4; + GLenum format = getFormat(desc.internalFormat);; + if (context.ES && format == GL_DEPTH_COMPONENT) { + format = GL_RED; } + GLuint channels = _gl_format_channels(format);; image::Image *image = new image::Image(desc.width, desc.height*desc.depth, channels, true); @@ -675,6 +795,8 @@ getBoundRenderbufferDesc(Context &context, ImageDesc &desc) glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_HEIGHT, &desc.height); desc.depth = 1; + glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_SAMPLES, &desc.samples); + glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_INTERNAL_FORMAT, &desc.internalFormat); return desc.valid(); @@ -890,6 +1012,8 @@ dumpReadBufferImage(JSONWriter &json, GLint width, GLint height, GLenum format, image::Image *image = new image::Image(width, height, channels, true); + while (glGetError() != GL_NO_ERROR) {} + // TODO: reset imaging state too context.resetPixelPackState(); @@ -897,7 +1021,16 @@ dumpReadBufferImage(JSONWriter &json, GLint width, GLint height, GLenum format, context.restorePixelPackState(); - json.writeImage(image, formatToString(internalFormat)); + GLenum error = glGetError(); + if (error != GL_NO_ERROR) { + do { + std::cerr << "warning: " << enumToString(error) << " while reading framebuffer\n"; + error = glGetError(); + } while(error != GL_NO_ERROR); + json.writeNull(); + } else { + json.writeImage(image, formatToString(internalFormat)); + } delete image; } @@ -906,7 +1039,9 @@ dumpReadBufferImage(JSONWriter &json, GLint width, GLint height, GLenum format, static inline GLuint downsampledFramebuffer(Context &context, GLuint oldFbo, GLint drawbuffer, - GLint colorRb, GLint depthRb, GLint stencilRb, + const ImageDesc &colorDesc, + const ImageDesc &depthDesc, + const ImageDesc &stencilDesc, GLuint *rbs, GLint *numRbs) { GLuint fbo; @@ -919,13 +1054,9 @@ downsampledFramebuffer(Context &context, { // color buffer - ImageDesc desc; - glBindRenderbuffer(GL_RENDERBUFFER, colorRb); - getBoundRenderbufferDesc(context, desc); - glGenRenderbuffers(1, &rbs[*numRbs]); glBindRenderbuffer(GL_RENDERBUFFER, rbs[*numRbs]); - glRenderbufferStorage(GL_RENDERBUFFER, desc.internalFormat, desc.width, desc.height); + glRenderbufferStorage(GL_RENDERBUFFER, colorDesc.internalFormat, colorDesc.width, colorDesc.height); glFramebufferRenderbuffer(GL_FRAMEBUFFER, drawbuffer, GL_RENDERBUFFER, rbs[*numRbs]); @@ -933,38 +1064,31 @@ downsampledFramebuffer(Context &context, glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); glDrawBuffer(drawbuffer); glReadBuffer(drawbuffer); - glBlitFramebuffer(0, 0, desc.width, desc.height, 0, 0, desc.width, desc.height, + glBlitFramebuffer(0, 0, colorDesc.width, colorDesc.height, 0, 0, colorDesc.width, colorDesc.height, GL_COLOR_BUFFER_BIT, GL_NEAREST); glBindFramebuffer(GL_FRAMEBUFFER, fbo); ++*numRbs; } - if (stencilRb == depthRb && stencilRb) { + if (stencilDesc == depthDesc && + depthDesc.valid()) { //combined depth and stencil buffer - ImageDesc desc; - glBindRenderbuffer(GL_RENDERBUFFER, depthRb); - getBoundRenderbufferDesc(context, desc); - glGenRenderbuffers(1, &rbs[*numRbs]); glBindRenderbuffer(GL_RENDERBUFFER, rbs[*numRbs]); - glRenderbufferStorage(GL_RENDERBUFFER, desc.internalFormat, desc.width, desc.height); + glRenderbufferStorage(GL_RENDERBUFFER, depthDesc.internalFormat, depthDesc.width, depthDesc.height); glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_STENCIL_ATTACHMENT, GL_RENDERBUFFER, rbs[*numRbs]); glBindFramebuffer(GL_READ_FRAMEBUFFER, oldFbo); glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); - glBlitFramebuffer(0, 0, desc.width, desc.height, 0, 0, desc.width, desc.height, + glBlitFramebuffer(0, 0, depthDesc.width, depthDesc.height, 0, 0, depthDesc.width, depthDesc.height, GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT, GL_NEAREST); glBindFramebuffer(GL_FRAMEBUFFER, fbo); ++*numRbs; } else { - if (depthRb) { - ImageDesc desc; - glBindRenderbuffer(GL_RENDERBUFFER, depthRb); - getBoundRenderbufferDesc(context, desc); - + if (depthDesc.valid()) { glGenRenderbuffers(1, &rbs[*numRbs]); glBindRenderbuffer(GL_RENDERBUFFER, rbs[*numRbs]); - glRenderbufferStorage(GL_RENDERBUFFER, desc.internalFormat, desc.width, desc.height); + glRenderbufferStorage(GL_RENDERBUFFER, depthDesc.internalFormat, depthDesc.width, depthDesc.height); glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_RENDERBUFFER, rbs[*numRbs]); @@ -972,18 +1096,14 @@ downsampledFramebuffer(Context &context, glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); glDrawBuffer(GL_DEPTH_ATTACHMENT); glReadBuffer(GL_DEPTH_ATTACHMENT); - glBlitFramebuffer(0, 0, desc.width, desc.height, 0, 0, desc.width, desc.height, + glBlitFramebuffer(0, 0, depthDesc.width, depthDesc.height, 0, 0, depthDesc.width, depthDesc.height, GL_DEPTH_BUFFER_BIT, GL_NEAREST); ++*numRbs; } - if (stencilRb) { - ImageDesc desc; - glBindRenderbuffer(GL_RENDERBUFFER, stencilRb); - getBoundRenderbufferDesc(context, desc); - + if (stencilDesc.valid()) { glGenRenderbuffers(1, &rbs[*numRbs]); glBindRenderbuffer(GL_RENDERBUFFER, rbs[*numRbs]); - glRenderbufferStorage(GL_RENDERBUFFER, desc.internalFormat, desc.width, desc.height); + glRenderbufferStorage(GL_RENDERBUFFER, stencilDesc.internalFormat, stencilDesc.width, stencilDesc.height); glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_STENCIL_ATTACHMENT, GL_RENDERBUFFER, rbs[*numRbs]); @@ -991,7 +1111,7 @@ downsampledFramebuffer(Context &context, glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); glDrawBuffer(GL_STENCIL_ATTACHMENT); glReadBuffer(GL_STENCIL_ATTACHMENT); - glBlitFramebuffer(0, 0, desc.width, desc.height, 0, 0, desc.width, desc.height, + glBlitFramebuffer(0, 0, stencilDesc.width, stencilDesc.height, 0, 0, stencilDesc.width, stencilDesc.height, GL_STENCIL_BUFFER_BIT, GL_NEAREST); ++*numRbs; } @@ -1081,6 +1201,8 @@ dumpFramebufferAttachment(JSONWriter &json, Context &context, GLenum target, GLe return; } + assert(desc.samples == 0); + json.beginMember(enumToString(attachment)); dumpReadBufferImage(json, desc.width, desc.height, format, desc.internalFormat); json.endMember(); @@ -1147,7 +1269,6 @@ dumpFramebuffer(JSONWriter &json, Context &context) } else if (context.ES) { dumpFramebufferAttachments(json, context, GL_FRAMEBUFFER); } else { - GLint colorRb = 0, stencilRb = 0, depthRb = 0; GLint draw_buffer0 = GL_NONE; glGetIntegerv(GL_DRAW_BUFFER0, &draw_buffer0); bool multisample = false; @@ -1155,42 +1276,27 @@ dumpFramebuffer(JSONWriter &json, Context &context) GLint boundRb = 0; glGetIntegerv(GL_RENDERBUFFER_BINDING, &boundRb); - GLint object_type; - glGetFramebufferAttachmentParameteriv(GL_DRAW_FRAMEBUFFER, draw_buffer0, GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE, &object_type); - if (object_type == GL_RENDERBUFFER) { - glGetFramebufferAttachmentParameteriv(GL_DRAW_FRAMEBUFFER, draw_buffer0, GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME, &colorRb); - glBindRenderbuffer(GL_RENDERBUFFER, colorRb); - GLint samples = 0; - glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_SAMPLES, &samples); - if (samples) { + ImageDesc colorDesc; + if (getFramebufferAttachmentDesc(context, GL_DRAW_FRAMEBUFFER, draw_buffer0, colorDesc)) { + if (colorDesc.samples) { multisample = true; } } - glGetFramebufferAttachmentParameteriv(GL_DRAW_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE, &object_type); - if (object_type == GL_RENDERBUFFER) { - glGetFramebufferAttachmentParameteriv(GL_DRAW_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME, &depthRb); - glBindRenderbuffer(GL_RENDERBUFFER, depthRb); - GLint samples = 0; - glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_SAMPLES, &samples); - if (samples) { + ImageDesc depthDesc; + if (getFramebufferAttachmentDesc(context, GL_DRAW_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, depthDesc)) { + if (depthDesc.samples) { multisample = true; } } - glGetFramebufferAttachmentParameteriv(GL_DRAW_FRAMEBUFFER, GL_STENCIL_ATTACHMENT, GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE, &object_type); - if (object_type == GL_RENDERBUFFER) { - glGetFramebufferAttachmentParameteriv(GL_DRAW_FRAMEBUFFER, GL_STENCIL_ATTACHMENT, GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME, &stencilRb); - glBindRenderbuffer(GL_RENDERBUFFER, stencilRb); - GLint samples = 0; - glGetRenderbufferParameteriv(GL_RENDERBUFFER, GL_RENDERBUFFER_SAMPLES, &samples); - if (samples) { + ImageDesc stencilDesc; + if (getFramebufferAttachmentDesc(context, GL_DRAW_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, stencilDesc)) { + if (stencilDesc.samples) { multisample = true; } } - glBindRenderbuffer(GL_RENDERBUFFER, boundRb); - GLuint rbs[3]; GLint numRbs = 0; GLuint fboCopy = 0; @@ -1200,14 +1306,16 @@ dumpFramebuffer(JSONWriter &json, Context &context) // to blit the fbo to a temporary one fboCopy = downsampledFramebuffer(context, boundDrawFbo, draw_buffer0, - colorRb, depthRb, stencilRb, + colorDesc, depthDesc, stencilDesc, rbs, &numRbs); + } else { + glBindFramebuffer(GL_READ_FRAMEBUFFER, boundDrawFbo); } - dumpFramebufferAttachments(json, context, GL_DRAW_FRAMEBUFFER); + dumpFramebufferAttachments(json, context, GL_READ_FRAMEBUFFER); if (multisample) { - glBindRenderbuffer(GL_RENDERBUFFER_BINDING, boundRb); + glBindRenderbuffer(GL_RENDERBUFFER, boundRb); glDeleteRenderbuffers(numRbs, rbs); glDeleteFramebuffers(1, &fboCopy); }