emacs: tree: use tag-format-tags

Previously tree did not use tag-format-tags: since tree wants to
distinguish matching messages from non-matching messages it is not a
perfect fit.

However, in preparation for allowing tag-changes to be shown (i.e.,
added or deleted tags to be indicated) it is convenient to make all
places displaying tags call the same routines.

We modify notmuch-tag-format-tags slightly so that it can take and
argument for the default characteristics of the face before the
special tag features are applied.

This also means that things like the star symbol for flagged messages
all work in tree.

diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
index b60f46c74d33ee5d70ec0feca703efb39fc60ecb..908e7ade6270bccce7fb6afbbb3e63eccc261465 100644 (file)
--- a/emacs/notmuch-tag.el
+++ b/emacs/notmuch-tag.el
@@ -148,15 +148,16 @@ This can be used with `notmuch-tag-format-image-data'."
        (dolist (format (cdr formats) tag)
          (setq tag (eval format))))))))
 
        (dolist (format (cdr formats) tag)
          (setq tag (eval format))))))))
 

-(defun notmuch-tag-format-tags (tags)
+(defun notmuch-tag-format-tags (tags &optional face)

   "Return a string representing formatted TAGS."
   "Return a string representing formatted TAGS."

-  (notmuch-combine-face-text-property-string
-   (mapconcat #'identity
-             ;; nil indicated that the tag was deliberately hidden
-             (delq nil (mapcar #'notmuch-tag-format-tag tags))
-             " ")
-   'notmuch-tag-face
-   t))
+  (let ((face (or face 'notmuch-tag-face)))
+    (notmuch-combine-face-text-property-string
+     (mapconcat #'identity
+               ;; nil indicated that the tag was deliberately hidden
+               (delq nil (mapcar #'notmuch-tag-format-tag tags))
+               " ")
+     face
+     t)))

 
 (defcustom notmuch-before-tag-hook nil
   "Hooks that are run before tags of a message are modified.
 
 (defcustom notmuch-before-tag-hook nil
   "Hooks that are run before tags of a message are modified.

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 16f28629327131a0654cf6e79b89a2ce752c0e49..4f2ac028793485d72bff372593432fff5ffcf3f5 100644 (file)
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -704,10 +704,7 @@ unchanged ADDRESS if parsing fails."
            (face (if match
                      'notmuch-tree-match-tag-face
                    'notmuch-tree-no-match-tag-face)))
            (face (if match
                      'notmuch-tree-match-tag-face
                    'notmuch-tree-no-match-tag-face)))

-       (propertize (format format-string
-                           (mapconcat #'identity tags " "))
-                   'face face))))))
-
+       (format format-string (notmuch-tag-format-tags tags face)))))))

 
 (defun notmuch-tree-format-field-list (field-list msg)
   "Format fields of MSG according to FIELD-LIST and return string"
 
 (defun notmuch-tree-format-field-list (field-list msg)
   "Format fields of MSG according to FIELD-LIST and return string"