strip out non-ascii characters from message ids, and improve documentation

diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 249b6c6e0ef03e55f715c3460c3d6a1bbc49889d..9b6063f48fb9f36e4a578aa4a9e8762dc9065fa3 100644 (file)
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -148,7 +148,18 @@ class Message
     @source.fn_for_offset @source_info
   end
 
-  def sanitize_message_id mid; mid.gsub(/\s+/, "")[0..254] end
+  ## sanitize message ids by removing spaces and non-ascii characters.
+  ## also, truncate to 255 characters. all these steps are necessary
+  ## to make ferret happy. of course, we probably fuck up a couple
+  ## valid message ids as well. as long as we're consistent, this
+  ## should be fine, though.
+  ##
+  ## also, mostly the message ids that are changed by this belong to
+  ## spam email.
+  ##
+  ## an alternative would be to SHA1 or MD5 all message ids on a regular basis.
+  ## don't tempt me.
+  def sanitize_message_id mid; mid.gsub(/(\s|[^\000-\177])+/, "")[0..254] end
 
   def save index
     return unless @dirty