]> git.cworth.org Git - sup/commitdiff
replace += with << in mbox reading
authorWilliam Morgan <wmorgan-sup@masanjin.net>
Sun, 26 Apr 2009 14:48:36 +0000 (10:48 -0400)
committerWilliam Morgan <wmorgan-sup@masanjin.net>
Sun, 26 Apr 2009 14:48:36 +0000 (10:48 -0400)
there's a tremendous speed difference between these two operators,
though neither of these points are bottlenecks.

lib/sup/mbox/loader.rb

index 7fe912900e16d477fc7d690873d92e9c623f48c2..fbf31ae4fe96cfff269e9d0d373b58ffa6a06d90 100644 (file)
@@ -86,7 +86,7 @@ class Loader < Source
     @mutex.synchronize do
       @f.seek offset
       until @f.eof? || (l = @f.gets) =~ /^\r*$/
-        ret += l
+        ret << l
       end
     end
     ret
@@ -94,7 +94,7 @@ class Loader < Source
 
   def raw_message offset
     ret = ""
-    each_raw_message_line(offset) { |l| ret += l }
+    each_raw_message_line(offset) { |l| ret << l }
     ret
   end