MBox::Loader#next determines labels with self.labels instead of @labels

This allows subclasses to define fixed #labels methods rather than
having to set a shared instance variable (which is one of the few
features of Ruby I actively hate.) SentLoader does this,

diff --git a/lib/sup/mbox/loader.rb b/lib/sup/mbox/loader.rb
index a66d7b906004f57b612c4888bc3111c674906547..4acc0645d90f99dd7ac5f77768a1b3e26c30e4a5 100644 (file)
--- a/lib/sup/mbox/loader.rb
+++ b/lib/sup/mbox/loader.rb
@@ -147,7 +147,7 @@ class Loader < Source
     end
 
     self.cur_offset = next_offset
-    [returned_offset, (@labels + [:unread]).uniq]
+    [returned_offset, (self.labels + [:unread]).uniq]
   end
 end