From: José Fonseca <jose.r.fonseca@gmail.com>
Date: Sun, 18 Nov 2012 15:45:27 +0000 (+0000)
Subject: cli: Rename replay -> retrace.
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;ds=sidebyside;h=ef7013981f3bf403b375a998faf49f4b8f59083c;p=apitrace

cli: Rename replay -> retrace.

For consistency with the current terminology.
---

diff --git a/cli/cli_dump.cpp b/cli/cli_dump.cpp
index f959568..e30f6cc 100644
--- a/cli/cli_dump.cpp
+++ b/cli/cli_dump.cpp
@@ -171,7 +171,6 @@ command(int argc, char *argv[])
         trace::Parser p;
 
         if (!p.open(argv[i])) {
-            std::cerr << "error: failed to open " << argv[i] << "\n";
             return 1;
         }
 
diff --git a/cli/cli_pickle.cpp b/cli/cli_pickle.cpp
index ffea40b..3a9129f 100644
--- a/cli/cli_pickle.cpp
+++ b/cli/cli_pickle.cpp
@@ -255,7 +255,6 @@ command(int argc, char *argv[])
         trace::Parser parser;
 
         if (!parser.open(argv[i])) {
-            std::cerr << "error: failed to open " << argv[i] << "\n";
             return 1;
         }
 
diff --git a/cli/cli_trim.cpp b/cli/cli_trim.cpp
index d944682..eea5553 100644
--- a/cli/cli_trim.cpp
+++ b/cli/cli_trim.cpp
@@ -110,7 +110,6 @@ command(int argc, char *argv[])
     for (i = optind; i < argc; ++i) {
         trace::Parser p;
         if (!p.open(argv[i])) {
-            std::cerr << "error: failed to open " << argv[i] << "\n";
             return 1;
         }
 
diff --git a/common/trace_file.hpp b/common/trace_file.hpp
index 411eccb..0c176aa 100644
--- a/common/trace_file.hpp
+++ b/common/trace_file.hpp
@@ -31,6 +31,11 @@
 #include <fstream>
 #include <stdint.h>
 
+
+#define SNAPPY_BYTE1 'a'
+#define SNAPPY_BYTE2 't'
+
+
 namespace trace {
 
 class File {
@@ -49,8 +54,6 @@ public:
     };
 
 public:
-    static bool isZLibCompressed(const std::string &filename);
-    static bool isSnappyCompressed(const std::string &filename);
     static File *createZLib(void);
     static File *createSnappy(void);
     static File *createForRead(const char *filename);
@@ -201,6 +204,6 @@ operator<=(const File::Offset &one, const File::Offset &two)
 }
 
 
-}
+} /* namespace trace */
 
 #endif
diff --git a/common/trace_file_read.cpp b/common/trace_file_read.cpp
index 68bc74a..46c83ff 100644
--- a/common/trace_file_read.cpp
+++ b/common/trace_file_read.cpp
@@ -24,6 +24,8 @@
  **************************************************************************/
 
 
+#include <fstream>
+
 #include "os.hpp"
 #include "trace_file.hpp"
 
@@ -34,17 +36,25 @@ using namespace trace;
 File *
 File::createForRead(const char *filename)
 {
-    File *file;
+    std::ifstream stream(filename, std::ifstream::binary | std::ifstream::in);
+    if (!stream.is_open()) {
+        os::log("error: failed to open %s\n", filename);
+        return NULL;
+    }
+    unsigned char byte1, byte2;
+    stream >> byte1;
+    stream >> byte2;
+    stream.close();
 
-    if (File::isSnappyCompressed(filename)) {
+    File *file;
+    if (byte1 == SNAPPY_BYTE1 && byte2 == SNAPPY_BYTE2) {
         file = File::createSnappy();
-    } else if (File::isZLibCompressed(filename)) {
+    } else if (byte1 == 0x1f && byte2 == 0x8b) {
         file = File::createZLib();
     } else  {
-        os::log("error: could not determine %s compression type\n", filename);
+        os::log("error: %s: unkwnown compression\n", filename);
         return NULL;
     }
-
     if (!file) {
         return NULL;
     }
diff --git a/common/trace_file_snappy.cpp b/common/trace_file_snappy.cpp
index c0727cd..f47c89b 100644
--- a/common/trace_file_snappy.cpp
+++ b/common/trace_file_snappy.cpp
@@ -63,8 +63,6 @@
 
 #define SNAPPY_CHUNK_SIZE (1 * 1024 * 1024)
 
-#define SNAPPY_BYTE1 'a'
-#define SNAPPY_BYTE2 't'
 
 
 using namespace trace;
@@ -406,18 +404,3 @@ int SnappyFile::rawPercentRead()
 File* File::createSnappy(void) {
     return new SnappyFile;
 }
-
-bool File::isSnappyCompressed(const std::string &filename)
-{
-    std::fstream stream(filename.c_str(),
-                        std::fstream::binary | std::fstream::in);
-    if (!stream.is_open())
-        return false;
-
-    unsigned char byte1, byte2;
-    stream >> byte1;
-    stream >> byte2;
-    stream.close();
-
-    return (byte1 == SNAPPY_BYTE1 && byte2 == SNAPPY_BYTE2);
-}
diff --git a/common/trace_file_zlib.cpp b/common/trace_file_zlib.cpp
index 5e5d5de..c4eed33 100644
--- a/common/trace_file_zlib.cpp
+++ b/common/trace_file_zlib.cpp
@@ -157,19 +157,3 @@ int ZLibFile::rawPercentRead()
 File * File::createZLib(void) {
     return new ZLibFile;
 }
-
-bool File::isZLibCompressed(const std::string &filename)
-{
-    std::fstream stream(filename.c_str(),
-                        std::fstream::binary | std::fstream::in);
-    if (!stream.is_open())
-        return false;
-
-    unsigned char byte1, byte2;
-    stream >> byte1;
-    stream >> byte2;
-    stream.close();
-
-    return (byte1 == 0x1f && byte2 == 0x8b);
-}
-
diff --git a/retrace/retrace_main.cpp b/retrace/retrace_main.cpp
index bc23bc4..27ff2b4 100644
--- a/retrace/retrace_main.cpp
+++ b/retrace/retrace_main.cpp
@@ -647,7 +647,6 @@ int main(int argc, char **argv)
 
     for (i = optind; i < argc; ++i) {
         if (!retrace::parser.open(argv[i])) {
-            std::cerr << "error: failed to open " << argv[i] << "\n";
             return 1;
         }