From: Carl Worth <cworth@cworth.org>
Date: Sat, 24 Apr 2010 00:27:14 +0000 (-0700)
Subject: emacs: Rename notmuch-show-toggle-all to notmuch-show-open-or-close-all
X-Git-Tag: 0.3~85
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;h=1291d1dcb17280d8a98ebd4197b4524ef89cf771;p=obsolete%2Fnotmuch-old

emacs: Rename notmuch-show-toggle-all to notmuch-show-open-or-close-all

The function was named and documented incorrectly before, saying that
it would "change the visibility of all messages". Instead it only
opens the messages that are closed---it doesn't simultanesously close
the messages that are open. (Granted, nobody would *want* that
behavior I don't think, but the naming was confusing before.)
---

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 95874bb2..203528fd 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -526,7 +526,7 @@ function is used. "
 	(define-key map "p" 'notmuch-show-previous-open-message)
 	(define-key map (kbd "DEL") 'notmuch-show-rewind)
 	(define-key map " " 'notmuch-show-advance-and-archive)
-	(define-key map (kbd "M-RET") 'notmuch-show-toggle-all)
+	(define-key map (kbd "M-RET") 'notmuch-show-open-or-close-all)
 	(define-key map (kbd "RET") 'notmuch-show-toggle-message)
 	map)
       "Keymap for \"notmuch show\" buffers.")
@@ -907,10 +907,10 @@ to stdout or stderr will appear in the *Messages* buffer."
      (not (plist-get props :message-visible))))
   (force-window-update))
 
-(defun notmuch-show-toggle-all ()
-  "Change the visibility all of the messages in the current
-thread. By default make all of the messages visible. With a
-prefix argument, make them all not visible."
+(defun notmuch-show-open-or-close-all ()
+  "Set the visibility all of the messages in the current thread.
+By default make all of the messages visible. With a prefix
+argument, hide all of the messages."
   (interactive)
   (save-excursion
     (goto-char (point-min))