From: José Fonseca <jose.r.fonseca@gmail.com>
Date: Sat, 24 Mar 2012 09:13:21 +0000 (+0000)
Subject: Defer reading all standard error.
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;h=149e71e4b1dc7521d78b471747e3c4ab1c9b5ddf;p=apitrace

Defer reading all standard error.

I'm not sure, but I suspect this may cause all standard output to be
buffered until the process finishes.
---

diff --git a/gui/retracer.cpp b/gui/retracer.cpp
index 59e4093..7a49ae9 100644
--- a/gui/retracer.cpp
+++ b/gui/retracer.cpp
@@ -184,13 +184,6 @@ void RetraceProcess::replayFinished(int exitCode, QProcess::ExitStatus exitStatu
 {
     QByteArray output;
     QString msg;
-    QString errStr = m_process->readAllStandardError();
-
-#if 0
-    qDebug()<<"Process finished = ";
-    qDebug()<<"\terr = "<<errStr;
-    qDebug()<<"\tout = "<<output;
-#endif
 
     if (exitStatus != QProcess::NormalExit) {
         msg = QLatin1String("Process crashed");
@@ -262,6 +255,7 @@ void RetraceProcess::replayFinished(int exitCode, QProcess::ExitStatus exitStatu
         }
     }
 
+    QString errStr = m_process->readAllStandardError();
     QStringList errorLines = errStr.split('\n');
     QList<ApiTraceError> errors;
     QRegExp regexp("(^\\d+): +(\\b\\w+\\b): (.+$)");