From: José Fonseca <jfonseca@vmware.com>
Date: Sat, 1 Jun 2013 09:26:58 +0000 (+0100)
Subject: retrace: Don't try to recreate existing directories.
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;h=1d4911e60ee7394669e258e2892e1e2246e61328;p=apitrace

retrace: Don't try to recreate existing directories.
---

diff --git a/common/os_posix.cpp b/common/os_posix.cpp
index 05ad8e9..7ddd895 100644
--- a/common/os_posix.cpp
+++ b/common/os_posix.cpp
@@ -128,9 +128,6 @@ String::exists(void) const
         return false;
     }
 
-    if (!S_ISREG(st.st_mode))
-        return false;
-
     return true;
 }
 
diff --git a/retrace/retrace_main.cpp b/retrace/retrace_main.cpp
index ddcc27f..8079cd6 100644
--- a/retrace/retrace_main.cpp
+++ b/retrace/retrace_main.cpp
@@ -727,8 +727,8 @@ int main(int argc, char **argv)
                 os::String::iterator sep = prefix.rfindSep(false);
                 if (sep != prefix.end()) {
                     prefix.erase(sep, prefix.end());
-                    if (!os::createDirectory(prefix)) {
-                        std::cerr << "error: failed to create " << prefix.str() << "\n";
+                    if (!prefix.exists() && !os::createDirectory(prefix)) {
+                        std::cerr << "error: failed to create `" << prefix.str() << "` directory\n";
                     }
                 }
             }