From: wmorgan <wmorgan@5c8cc53c-5e98-4d25-b20a-d8db53a31250>
Date: Mon, 10 Dec 2007 03:55:53 +0000 (+0000)
Subject: be better about picking extensions for attachments
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;h=4101d2af352441d698477398f4fe76ece3906c8b;p=sup

be better about picking extensions for attachments

git-svn-id: svn://rubyforge.org/var/svn/sup/trunk@760 5c8cc53c-5e98-4d25-b20a-d8db53a31250
---

diff --git a/lib/sup/message.rb b/lib/sup/message.rb
index 69625fc..fbea1f6 100644
--- a/lib/sup/message.rb
+++ b/lib/sup/message.rb
@@ -359,8 +359,16 @@ private
 
         ## haven't found one, but it's a non-text message. fake
         ## it.
+        ##
+        ## TODO: make this less lame.
         elsif m.header["Content-Type"] && m.header["Content-Type"] !~ /^text\/plain/
-          "sup-attachment-#{Time.now.to_i}-#{rand 10000}"
+          extension =
+            case m.header["Content-Type"]
+            when /text\/html/: "html"
+            when /image\/(.*)/: $1
+            end
+
+          ["sup-attachment-#{Time.now.to_i}-#{rand 10000}", extension].join(".")
         end
 
       ## if there's a filename, we'll treat it as an attachment.