From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Date: Sat, 10 Mar 2012 01:24:50 +0000 (+0400)
Subject: test: remove "Generate some messages" test from raw
X-Git-Tag: 0.13_rc1~148
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;h=6511b08fb81add535b56a183f278b48a45fc9875;p=notmuch-old

test: remove "Generate some messages" test from raw

Before the change, the first subtest in raw format tests just
generated messages and checked that they are added successfully.  This
is not really a raw format test, it is creating of environment
required for other subtests to run.  The patch removes the first
subtest from raw and replaces it with bare add_message calls, similar
to how it is done in other tests.

TODO: we should check that test environment was created successfully.
Currently, many tests do add_message(), notmuch new and other calls
without checking the results.  We should come up with a general
solution for this, i.e. if any command during test initialization
fails, all tests should be skipped with appropriate error message.
---

diff --git a/test/raw b/test/raw
index 0171e641..de0b8677 100755
--- a/test/raw
+++ b/test/raw
@@ -3,11 +3,8 @@
 test_description='notmuch show --format=raw'
 . ./test-lib.sh
 
-test_begin_subtest "Generate some messages"
-generate_message
-generate_message
-output=$(NOTMUCH_NEW)
-test_expect_equal "$output" "Added 2 new messages to the database."
+add_message
+add_message
 
 test_begin_subtest "Attempt to show multiple raw messages"
 output=$(notmuch show --format=raw "*" 2>&1)