From: David Bremner <david@tethera.net>
Date: Sun, 3 Dec 2023 18:56:44 +0000 (-0400)
Subject: lib: clear error message on success in _choose_database_path
X-Git-Tag: 0.38.3~5
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;h=b97cd90040a8353e6f94c317af2020f3d6e67a2e;hp=5a582e8ed9b9bfd88e63149fb671510bc2b2e9f8;p=notmuch

lib: clear error message on success in _choose_database_path

Previously we both found a database and returned a message saying that
the database could not be found (along with a success code). This
change should prevent spurious error output.
---

diff --git a/lib/open.cc b/lib/open.cc
index 005872dc..463e38bf 100644
--- a/lib/open.cc
+++ b/lib/open.cc
@@ -249,6 +249,11 @@ _choose_database_path (notmuch_database_t *notmuch,
 	return NOTMUCH_STATUS_NO_DATABASE;
     }
 
+    if (*message) {
+	free (*message);
+	*message = NULL;
+    }
+
     return NOTMUCH_STATUS_SUCCESS;
 }
 
diff --git a/test/T055-path-config.sh b/test/T055-path-config.sh
index fcaf09d3..1feb5624 100755
--- a/test/T055-path-config.sh
+++ b/test/T055-path-config.sh
@@ -376,7 +376,6 @@ EOF
 	   ;;
        home_mail|maildir_env)
 	   test_begin_subtest "No errors from config list ($config)"
-	   test_subtest_known_broken
 	   notmuch config list 2>OUTPUT 1>/dev/null
 	   test_expect_equal_file /dev/null OUTPUT
 	   ;;