From: Zack Rusin <zack@kde.org>
Date: Sun, 8 May 2011 04:52:13 +0000 (-0400)
Subject: Show call name on glGetError warning messages.
X-Git-Url: https://git.cworth.org/git?a=commitdiff_plain;h=c90658521fa879fc439608099563ce491b69dfdc;p=apitrace

Show call name on glGetError warning messages.
---

diff --git a/glretrace.hpp b/glretrace.hpp
index 24268fe..7c0ea6b 100644
--- a/glretrace.hpp
+++ b/glretrace.hpp
@@ -54,7 +54,7 @@ extern const char *snapshot_prefix;
 extern unsigned dump_state;
 
 void
-checkGlError(int callIdx = -1);
+checkGlError(const Trace::Call &call);
 
 void retrace_call_glx(Trace::Call &call);
 void retrace_call_wgl(Trace::Call &call);
diff --git a/glretrace.py b/glretrace.py
index d5b254f..9b46160 100644
--- a/glretrace.py
+++ b/glretrace.py
@@ -145,7 +145,7 @@ class GlRetracer(Retracer):
             print '    glretrace::insideGlBeginEnd = true;'
         elif function.name.startswith('gl'):
             # glGetError is not allowed inside glBegin/glEnd
-            print '    glretrace::checkGlError(call.no);'
+            print '    glretrace::checkGlError(call);'
 
         if function.name == 'glFlush':
             print '    if (!glretrace::double_buffer) {'
diff --git a/glretrace_main.cpp b/glretrace_main.cpp
index 0e9e6bd..1867b78 100644
--- a/glretrace_main.cpp
+++ b/glretrace_main.cpp
@@ -53,7 +53,7 @@ const char *snapshot_prefix = NULL;
 unsigned dump_state = ~0;
 
 void
-checkGlError(int callIdx) {
+checkGlError(const Trace::Call &call) {
     if (benchmark || insideGlBeginEnd) {
         return;
     }
@@ -63,11 +63,11 @@ checkGlError(int callIdx) {
         return;
     }
 
-    if (callIdx >= 0) {
-        std::cerr << callIdx << ": ";
-    }
+    std::cerr << call.no << ": ";
+    std::cerr << "warning: glGetError(";
+    std::cerr << call.name();
+    std::cerr << ") = ";
 
-    std::cerr << "warning: glGetError() = ";
     switch (error) {
     case GL_INVALID_ENUM:
         std::cerr << "GL_INVALID_ENUM";
@@ -108,7 +108,6 @@ static void snapshot(Image::Image &image) {
     glGetIntegerv(GL_READ_BUFFER, &readbuffer);
     glReadBuffer(drawbuffer);
     glReadPixels(0, 0, image.width, image.height, GL_RGBA, GL_UNSIGNED_BYTE, image.pixels);
-    checkGlError();
     glReadBuffer(readbuffer);
 }