David Bremner [Sun, 9 Feb 2025 19:03:46 +0000 (15:03 -0400)]
debian: stop packaging legacy python bindings.
This is in preparation for moving them to contrib and dropping them
from the test suite upstream.
Damien Cassou [Sun, 16 Feb 2025 21:22:23 +0000 (22:22 +0100)]
notmuch-show-imenu-prev-index-position-function: Don't recenter
The previous version of
notmuch-show-imenu-prev-index-position-function was calling
notmuch-show-previous-message which was recentering the window. This
is a problem when which-func-mode is active because which-func-mode is
called each time the user moves point around.
Because this function is only meant to be executed by imenu, there is
no reason to recenter the window. For the same reason, the new
implementation doesn't have to follow strictly how
notmuch-show-previous-message is implemented because imenu only places
point at very specific locations before calling
notmuch-show-imenu-prev-index-position-function.
Lars Kotthoff [Thu, 6 Feb 2025 02:52:51 +0000 (19:52 -0700)]
fix segfaults in Python cFFI API and add tests
Several iterators in the Python cFFI API destroyed the objects they iterated
over too early (when the iterator was exhausted), causing subsequent segfaults
in common cases like creating a list from the iterator. This patch fixes the
segfaults and add tests to ensure that they don't happen again.
David Bremner [Sun, 26 Jan 2025 15:30:28 +0000 (11:30 -0400)]
Revert "bump versions to 0.39~rc0"
This reverts commit
deea909993513ec6fd800b7571649582d994dcbc.
David Bremner [Sun, 26 Jan 2025 13:46:43 +0000 (09:46 -0400)]
docs: add 2025 to copyright years
David Bremner [Sun, 26 Jan 2025 13:44:59 +0000 (09:44 -0400)]
bump versions to 0.39~rc0
Prepare to release a snapshot for testing
David Bremner [Sun, 26 Jan 2025 13:42:55 +0000 (09:42 -0400)]
debian: update changelog for 0.39~rc0-1
Fredrik Lönnegren [Thu, 5 Dec 2024 16:45:50 +0000 (17:45 +0100)]
docs: Update intersphinx_mapping
Running `make dirhtml` in bindings/python/docs generates the following
error:
```
sphinx-build -b dirhtml -d build/doctrees source build/dirhtml
Running Sphinx v8.0.2
loading translations [en]... done
making output directory... done
Converting `source_suffix = '.rst'` to `source_suffix = {'.rst': 'restructuredtext'}`.
ERROR: Invalid value `None` in intersphinx_mapping['https://docs.python.org/']. Expected a two-element tuple or list.
```
This commit updates intersphinx_mapping to follow the latest docs [1]
[1] https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html
Signed-off-by: Fredrik Lönnegren <fredrik@frelon.se>
David Bremner [Sat, 17 Aug 2024 17:00:46 +0000 (14:00 -0300)]
NEWS: deprecate Emacs older than 27.1
The current requirement of 25.1 is more than 5 years old at this
point.
Pengji Zhang [Fri, 16 Aug 2024 08:25:48 +0000 (16:25 +0800)]
emacs/mua: Correct autoload cookies
This is a follow-up to [1:
8d06dfce]. Per Info node '(elisp)Autoload',
autoload cookies should start with ';;;###'.
1: 2024-04-04
8d06dfce175593aebae9a759c9167df4988a3444
emacs: Autoload notmuch-user-agent related functions
David Bremner [Fri, 9 Aug 2024 13:18:54 +0000 (10:18 -0300)]
Revert "emacs: Fix saved-search buffer titles"
This reverts commit
bc989209171d406b3671024542e59b86b0ecb23d.
This was applied unintentionally to master while still under discussion.
David Bremner [Mon, 20 May 2024 11:58:58 +0000 (08:58 -0300)]
emacs/tree: sanitize subjects when drawing tree
This fixes the bug reported in
id:
6F2EF901-8B4B-44FF-83C5-
22F732BA95A6@gmail.com
Unfortunately it turns out our test data has several tabs in the
subject lines. The expected output was updated to reflect their
removal and the ripple effect of several more subjects matching the
previous ones.
David Bremner [Mon, 20 May 2024 11:58:57 +0000 (08:58 -0300)]
test/emacs-tree: add known broken test for subject with CR/NL
The test is intentionally vague as it's hard to pin down the correct
output before the code is fixed.
David Bremner [Mon, 20 May 2024 11:58:56 +0000 (08:58 -0300)]
test/emacs-show: add regression test for subjects with CR/NL
This subject is known to be problematic for notmuch-tree.
David Bremner [Thu, 21 Dec 2023 17:04:00 +0000 (09:04 -0800)]
CLI/show: warn if crypto options are used with mbox format
This limitation seems somewhat hard to fix, but at least try to warn
users when combining crypto operations with mbox output format.
Because the default is --decrypt=auto, the warning is omitted if
--decrypt=auto is specified. While this is not great, it seems more
wrong to always warn, or to change the default because of this.
Rudolf Adamkovič [Wed, 13 Dec 2023 21:39:02 +0000 (22:39 +0100)]
emacs: Fix saved-search buffer titles
REPRODUCTION STEPS:
(let ((notmuch-saved-searches
(list (list :name "Emacs List"
:query "query:lists-emacs")
(list :name "All Lists"
:query "query:lists"))))
(notmuch-search-buffer-title "query:lists-emacs" ))
ACTUAL:
"*notmuch-saved-search-[ All Lists ]-emacs*"
EXPECTED:
"*notmuch-saved-search-Emacs List*"
David Bremner [Mon, 29 Jul 2024 11:04:44 +0000 (08:04 -0300)]
devel: document emacs keybindings u and U
Thanks to changing the column widths to accomodate longer function
names, the diff is rather large, but the content is two new rows for
'u' and 'U'
David Bremner [Mon, 5 Aug 2024 13:31:24 +0000 (10:31 -0300)]
Merge branch 'release'
David Bremner [Mon, 5 Aug 2024 13:14:40 +0000 (10:14 -0300)]
debian: migrate build dependency to pkgconf
pkgconf is apparently the annointed successor to pkg-config, at least
in Debian.
David Bremner [Mon, 5 Aug 2024 11:48:24 +0000 (08:48 -0300)]
debian: skip T810-tsan everywhere
Not sure whose fault the failure is, but for now skip the test.
David Bremner [Mon, 5 Aug 2024 10:03:07 +0000 (07:03 -0300)]
debian: drop build conflicts on gdb-minimal
Recent gdb Provides gdb-minimal, so we can't conflict with it and
require gdb.
This may cause problems for people building in dirty environments for
older gdb, but there is not much we can do.
Nicholas D Steeves [Sat, 3 Aug 2024 18:56:09 +0000 (14:56 -0400)]
Add Astroid as an alternative Recommends; this one is a GUI client
that may be less intimidating for new users.
Nicholas D Steeves [Sat, 3 Aug 2024 18:56:08 +0000 (14:56 -0400)]
Allow neomutt to fulfill the "mutt" requirement of notmuch-mutt, and
add related Enhances (Closes: #
1029190).
Nicholas D Steeves [Sat, 3 Aug 2024 18:56:07 +0000 (14:56 -0400)]
Add changelog entry for James McCoy's work
James McCoy [Sat, 3 Aug 2024 18:56:06 +0000 (14:56 -0400)]
Convert notmuch-vim to Vim addon policy 2.0
The new Vim addon policy relies on Vim's native package functionality,
rather than the Debian-specific vim-addons tool. This allows the addon
to be immediately available when the package is installed, rather than
requiring extra setup by the user.
* Install notmuch-vim to its own /usr/share/notmuch-vim directory, so
the files are self-contained.
* Remove vim-addon-manager from notmuch-vim Depends
* Add ${vim-addon:Depends} to notmuch-vim Depends to ensure it has the
required relationships on Vim/Neovim.
* Build-Depend on dh-sequence-vim-addon to automatically setup the
required symlinks for Vim and Neovim to see the addon.
Signed-off-by: James McCoy <jamessan@debian.org>
Lars Kotthoff [Fri, 22 Dec 2023 21:06:34 +0000 (14:06 -0700)]
config: allow custom separators in author lists
Allow distinguishing between commas separating authors and separating
first and last names.
Amended by db: reformat NEWS entry and commit message. Tweaked
whitespace in lib/thread.cc.
David Bremner [Fri, 26 Jul 2024 03:01:38 +0000 (12:01 +0900)]
changelog for 0.38.3-2
Tony Zorman [Sun, 29 Oct 2023 07:25:21 +0000 (08:25 +0100)]
test/emacs: test notmuch-mua-subject-check
Amended by db: rename test file to avoid collision.
Tony Zorman [Sun, 29 Oct 2023 07:26:32 +0000 (08:26 +0100)]
emacs/mua: optionally check for erroneous subjects
This works much like notmuch-mua-attachment-regexp, but for the
subject instead. By default, check for empty subjects, as that seems a
reasonable thing to safeguard against.
David Bremner [Thu, 21 Sep 2023 19:50:02 +0000 (16:50 -0300)]
CLI: update commentary in config file to better match code
This comment has been out of date since notmuch 0.32. Although it
isn't really possible to explain all the options here, explain both
one new "split" way of doing things and the traditional one with
database inside $MAIL_ROOT/.notmuch.
Kevin Boulain [Sun, 27 Aug 2023 12:31:02 +0000 (14:31 +0200)]
lib: thread-safe s-expression query parser
Follow-up of
6273966d, now that sfsexp 1.4.1 doesn't rely on globals
anymore by default (https://github.com/mjsottile/sfsexp/issues/21).
This simply defers the initial query generation to use the thread-safe
helper (xapian_query_match_all) instead of Xapian::Query::MatchAll.
David Bremner [Sat, 22 Jul 2023 12:15:56 +0000 (09:15 -0300)]
emacs/hello: refresh hello directly
According to the now deleted commentary, the hack of using run-at-time
was needed for Emacs 24. It seems to be no longer needed for Emacs
28.2, and removing it makes further changes to the code simpler.
David Bremner [Mon, 3 Apr 2023 10:22:48 +0000 (07:22 -0300)]
CLI/git: add reset command
Sometimes merging is not what we want with tags; in particular it
tends to keep tags in the local repo that have been removed elsewhere.
This commit provides a new reset command; the reset itself is trivial,
but the work is to provide a safety check that uses the existing
--force and git.safe_fraction machinery.
Michael J Gruber [Mon, 17 Jun 2024 19:28:25 +0000 (21:28 +0200)]
Replace `delete-line` with its definition
37c022ae ("Use `without-restriction` in `with-temporary-notmuch-message-buffer`", 2024-03-14)
introduced `delete-line` in a test, but this is Emacs 29 and above only.
Replace it with its (almost) definition.
Michael J Gruber [Mon, 17 Jun 2024 19:28:24 +0000 (21:28 +0200)]
Replace `without-restriction` with `save-restriction`
37c022ae ("Use `without-restriction` in `with-temporary-notmuch-message-buffer`", 2024-03-14)
introduced a fix for draft saving in a way which is supported on Emacs
29 and above only. Replace this with a construct which we have used
before, so that we keep the same compatibility level.
Marc Fargas [Thu, 14 Mar 2024 14:56:49 +0000 (15:56 +0100)]
Use `without-restriction` in `with-temporary-notmuch-message-buffer`
This ensures that the temporary copy of the current message-mode
buffer is whole and not limited by a current restriction.
An example of such restriction is the default one established by
message-mode when composing a reply, that hides the References,
In-Reply-To and similar headers.
David Bremner [Sun, 26 May 2024 12:52:32 +0000 (09:52 -0300)]
test/cli: Add known broken test for (missing) quoting in From
In [1], Jakub Wilk observes that the current behaviour is confusing
since it looks like there are two mailboxes in From, while in fact
there is only one. It seems to me that notmuch should at least quote
the display-name part of a mailbox if it has "funny" characters in it,
and perhaps always quote it. Either way will require changing the
indexing code, since the structure is lost when writing the headers to
the database.
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=
1021614
David Bremner [Wed, 29 May 2024 10:15:26 +0000 (07:15 -0300)]
emacs/show: fix for text/calendar display
In certain scenarios involving symlinks and setting
find-file-visit-truename, text/calendar parts were not displayed
properly.
Following a suggestion of Al Haji-Ali [1], replace the use of
get-file-buffer with find-buffer-visiting.
[1]: id:m2wmneguh8.fsf@gmail.com
David Bremner [Wed, 29 May 2024 10:15:25 +0000 (07:15 -0300)]
test/emacs: add tests for rendering text/calendar parts
The first test is just a general regression test, while the second
duplicates the problem discussed in the thread starting at [1].
[1]: id:m2leo2u0uo.fsf@gmail.com
David Bremner [Wed, 29 May 2024 10:15:24 +0000 (07:15 -0300)]
test/emacs: add regression test for display of calendar parts.
This will hopefully catch breakage due to either changes in
Emacs (especially Gnus) or changes to the notmuch-show code.
David Bremner [Wed, 29 May 2024 10:15:23 +0000 (07:15 -0300)]
test/corpora: add example with text/calendar attachment
Initially for testing rendering in Emacs.
Mohsin Kaleem [Fri, 19 Apr 2024 18:25:06 +0000 (19:25 +0100)]
emacs: Allow customizing :excluded in notmuch-saved-searches
Provide customize support for the new feature introduced in
cd89065d.
Commit message expanded by: db
David Bremner [Mon, 20 May 2024 11:58:55 +0000 (08:58 -0300)]
test: re-enable duplicate UI tests in T460-emacs-tree
These were disabled (accidentally?) in
f63d14a8c12a.
Mohsin Kaleem [Sun, 10 Mar 2024 18:57:41 +0000 (18:57 +0000)]
emacs: Add new option notmuch-search-hide-excluded
The new notmuch-search-hide-excluded option allows users to configure whether
to show or hide excluded messages (as determined by search.exclude_tags
in the local notmuch config file). It defaults to true for now to maintain
backwards-compatibility with how notmuch-{search,tree} already worked.
New commands notmuch-search-toggle-hide-excluded and
notmuch-tree-toggle-exclude have also been added. They toggle the value
of notmuch-search-hide-excluded for the search in the current search or
tree buffer. It's bound to "i" in the respective keymaps for these
modes.
Lastly I've amended some calls to notmuch-tree and notmuch-unthreaded
which didn't pass through the buffer local value of
notmuch-search-oldest-first (and now notmuch-search-exclude).
Examples of where I've done this include:
+ notmuch-jump-search
+ notmuch-tree-from-search-current-query
+ notmuch-unthreaded-from-search-current-query
+ notmuch-tree-from-search-thread
A new test file for Emacs has been added which covers the usage of the
new `notmuch-search-hide-excluded' option and interactively hiding or
showing mail with excluded tags. These test cover the basic usage of
the `notmuch-search-toggle-hide-excluded' command in notmuch-search,
notmuch-tree and notmuch-unthreaded searches. These tests also cover
the persistence of the current value of the hide-excluded mail option
as a user switches from between these different search commands.
[1]: id:87ilxlxsng.fsf@kisara.moe
Amended-by: db, fix indentation in T461-emacs-search-exclude.sh
David Bremner [Sat, 30 Sep 2023 11:40:50 +0000 (08:40 -0300)]
perf-test/tag: add maildir sync tests
Today someone asked me the (reasonable) question of how much
performance impact there is from synching tags to maildir flags. It
turns out it is noticeable, about a 50% overhead compared to
non-synched tags (according to these tests). In practice I don't know
if it's a big problem for users, since I don't know what fraction of
tagging operations involve "special" tags.
Jelle Licht [Tue, 19 Mar 2024 21:31:00 +0000 (22:31 +0100)]
emacs: Autoload notmuch-user-agent related functions
With this change, users with mail-user-agent set to
'notmuch-user-agent can start composing emails without having to
require 'notmuch-mua first.
Dmitry Bogatov [Tue, 26 Mar 2024 23:47:22 +0000 (19:47 -0400)]
emacs: Mark "notmuch-tree" command for autoloading
Some people (e.g: me) prefer to read their email with threaded
representation by default.
Without this commit, I have to run "notmuch-search" (autoloaded)
first to get "notmuch-tree" loaded.
Tomi Ollila [Tue, 12 Mar 2024 08:25:19 +0000 (10:25 +0200)]
NEWS: aspell(1)d few words
Executed aspell -l en -c NEWS
and replaced few obvious cases.
David Bremner [Mon, 11 Mar 2024 11:17:40 +0000 (08:17 -0300)]
Merge tag 'debian/0.38.3-1'
notmuch release 0.38.3-1 for unstable (sid) [dgit]
[dgit distro=debian no-split --quilt=linear]
David Bremner [Sun, 10 Mar 2024 03:13:32 +0000 (23:13 -0400)]
debian: update changelog date
It is a bit weird to have debian changelog before upstream release date.
David Bremner [Sun, 10 Mar 2024 03:07:21 +0000 (23:07 -0400)]
Merge from sid [dgit]
David Bremner [Sun, 10 Mar 2024 03:01:43 +0000 (23:01 -0400)]
Revert "debian: start changelog for 0.38.3-1"
This reverts commit
522b279e46c84e4d2d52ccdf082d05fc111dc7b5.
Remove duplicate changelog stanza
David Bremner [Sun, 10 Mar 2024 02:51:06 +0000 (22:51 -0400)]
version: bump to 0.38.3
David Bremner [Sun, 10 Mar 2024 02:49:50 +0000 (22:49 -0400)]
debian: start changelog for 0.38.3-1
David Bremner [Sun, 10 Mar 2024 02:47:37 +0000 (22:47 -0400)]
doc: update copyright years to include 2024
David Bremner [Sun, 10 Mar 2024 02:42:08 +0000 (22:42 -0400)]
NEWS: update for 0.38.3
Benjamin Drung [Wed, 28 Feb 2024 23:56:48 +0000 (23:56 +0000)]
Record notmuch (0.38.2-1.1) in archive suite sid
Benjamin Drung [Wed, 28 Feb 2024 23:56:48 +0000 (23:56 +0000)]
notmuch (0.38.2-1.1) unstable; urgency=medium
* Non-maintainer upload.
* Rename libraries for 64-bit time_t transition. Closes: #
1063205
[dgit import unpatched notmuch 0.38.2-1.1]
Benjamin Drung [Wed, 28 Feb 2024 23:56:48 +0000 (23:56 +0000)]
Import notmuch_0.38.2-1.1.debian.tar.xz
[dgit import tarball notmuch 0.38.2-1.1 notmuch_0.38.2-1.1.debian.tar.xz]
David Bremner [Sat, 17 Feb 2024 13:04:32 +0000 (09:04 -0400)]
debian: recommend gpg-agent instead of gnupg agent
Jakub Wilk [Fri, 12 Jan 2024 16:27:50 +0000 (17:27 +0100)]
CLI/git: remove no-op format() call
Jakub Wilk [Fri, 12 Jan 2024 16:27:49 +0000 (17:27 +0100)]
CLI/git: fix name error
Jakub Wilk [Fri, 12 Jan 2024 16:27:48 +0000 (17:27 +0100)]
CLI/git: remove unused import
shutil was used only for the tempfile.TemporaryDirectory backport,
which was removed in commit
b7c31f658121a0cf ("CLI/git: drop support for
python < 3.2").
David Bremner [Wed, 6 Dec 2023 11:39:24 +0000 (07:39 -0400)]
Merge branch 'release'
David Bremner [Sun, 3 Dec 2023 18:56:44 +0000 (14:56 -0400)]
lib: clear error message on success in _choose_database_path
Previously we both found a database and returned a message saying that
the database could not be found (along with a success code). This
change should prevent spurious error output.
David Bremner [Sun, 3 Dec 2023 15:41:11 +0000 (11:41 -0400)]
test: add known broken test for incorrect error message
Duplicate bug reported in id:87wmtvcor5.fsf@alyssa.is
The error message is nonsense, because notmuch config list actually
includes the database in those two cases.
David Bremner [Fri, 1 Dec 2023 12:11:39 +0000 (08:11 -0400)]
Merge branch 'release'
David Bremner [Fri, 1 Dec 2023 11:51:31 +0000 (07:51 -0400)]
debian: changelog for 0.38.2-1
David Bremner [Fri, 1 Dec 2023 11:51:09 +0000 (07:51 -0400)]
Import notmuch_0.38.2.orig.tar.xz
[dgit import orig notmuch_0.38.2.orig.tar.xz]
David Bremner [Fri, 1 Dec 2023 11:50:27 +0000 (07:50 -0400)]
NEWS for 0.38.2
David Bremner [Fri, 1 Dec 2023 11:38:55 +0000 (07:38 -0400)]
version: bump to 0.38.2
Jani Nikula [Thu, 30 Nov 2023 16:13:19 +0000 (18:13 +0200)]
notmuch-emacs-mua: avoid extra separators at the end of the line
Currently the --to/--cc/--bcc options add "user@example.com, " to the
message headers, with the the unnecessary ", " separator after the
last address, regardless of how many addresses are being added.
This used to be fine, but with recent emacs mm, trying to send the
email with the trailing commas leads to prompt:
Email address looks invalid; send anyway? (y or n)
Fix this by only adding the commas between addresses, avoiding the
trailing commas.
David Bremner [Tue, 28 Nov 2023 13:21:11 +0000 (09:21 -0400)]
Merge branch 'release'
David Bremner [Sat, 25 Nov 2023 12:33:52 +0000 (08:33 -0400)]
lib/string_map: simulate stable sorting
qsort(3) does not promise stability, and recent versions of glibc have
been showing more unstable behaviour [2]. Michael Gruber observed [1] test
breakage due to changing output order for message properties.
We provide a sorting order of (key,value) pairs that _looks_ stable by
breaking ties based on value if keys are equal. Internally there may
be some instability in the case of duplicate (key,value) pairs, but it
should not be observable via the iterator API.
[1]: id:CAA19uiSHjVFmwH0pMC7WwDYCOSzu3yqNbuYhu3ZMeNNRh313eA@mail.gmail.com
[2]: id:87msv3i44u.fsf@oldenburg.str.redhat.com
David Bremner [Thu, 26 Oct 2023 23:34:31 +0000 (20:34 -0300)]
Merge tag '0.38.1'
notmuch 0.38.1 release
David Bremner [Thu, 26 Oct 2023 23:02:05 +0000 (20:02 -0300)]
debian: update changelog for 0.38.1-1
David Bremner [Thu, 26 Oct 2023 22:52:27 +0000 (19:52 -0300)]
NEWS: News for 0.38.1
Just note the 3 bug fixes.
David Bremner [Thu, 26 Oct 2023 22:45:04 +0000 (19:45 -0300)]
version: bump to 0.38.1
No changes from 0.38.1~rc1
David Bremner [Thu, 12 Oct 2023 22:58:05 +0000 (19:58 -0300)]
Merge tag '0.38.1_rc1'
notmuch 0.38.1~rc1 release
David Bremner [Thu, 12 Oct 2023 22:54:07 +0000 (19:54 -0300)]
changelog for 0.38.1~rc1-1
David Bremner [Thu, 12 Oct 2023 22:52:42 +0000 (19:52 -0300)]
version: update to 0.38.1~rc1
Paul Wise [Thu, 12 Oct 2023 08:14:44 +0000 (16:14 +0800)]
notmuch-mutt: fix Perl syntax of hash index lookups
Fixes: commit 239fdbbbf0cbd6cd6ebafb87e88cdb3cded75364
David Bremner [Fri, 6 Oct 2023 23:08:17 +0000 (20:08 -0300)]
emacs/mua: change name of ignored parameter
Suppress compiler warning.
David Bremner [Fri, 6 Oct 2023 23:01:09 +0000 (20:01 -0300)]
emacs/address: rewrite docstring for n-a-selection-function
The previous version essentially repeated the source code, and
generated a compiler warning.
David Bremner [Fri, 6 Oct 2023 22:56:17 +0000 (19:56 -0300)]
emacs: wrap docstrings
Suppress byte-compiler warnings about >80 character docstrings.
David Bremner [Sun, 1 Oct 2023 11:43:11 +0000 (08:43 -0300)]
emacs: update quoting in docstrings
The complicated looking escapes are needed to avoid compile time
warnings. (info "(elisp) Text Quoting Style") for details.
David Bremner [Sun, 1 Oct 2023 11:26:17 +0000 (08:26 -0300)]
Merge tag 'debian/0.38.1_pre0-1'
notmuch release 0.38.1~pre0-1 for experimental (rc-buggy) [dgit]
[dgit distro=debian no-split --quilt=linear]
David Bremner [Sun, 1 Oct 2023 11:16:48 +0000 (08:16 -0300)]
debian: finalize changelog for 0.38.1~pre0-1
Bonus typo fix.
David Bremner [Sun, 1 Oct 2023 11:12:36 +0000 (08:12 -0300)]
Merge tag '0.38.1_pre0'
notmuch 0.38.1~pre0 release
David Bremner [Sun, 24 Sep 2023 09:51:52 +0000 (06:51 -0300)]
emacs/show: special case toggling display of images
According to emacs upstream [1], we can't expect overlay invisibility
and images to get along. This commit uses the previously stashed
undisplayer functions to actually remove the images from the buffer.
When the image is toggled, it is essentially redisplayed from scratch,
using the previously stashed redisplay data.
[1]: https://lists.gnu.org/archive/html/emacs-devel/2023-08/msg00593.html
David Bremner [Sun, 24 Sep 2023 09:51:51 +0000 (06:51 -0300)]
emacs: save image redisplay data during non-lazy display
This data will eventually be used to redisplay hidden images. A
certain amount of refactoring is done here to avoid code
duplication.
David Bremner [Sun, 24 Sep 2023 09:51:50 +0000 (06:51 -0300)]
emacs/show: save redisplay redisplay data when showing lazy part.
This data will be used to redisplay an image that is hidden by
deleting it from the buffer. We cannot easily delay until the image
is hidden, as we won't have the original data at that point.
David Bremner [Sun, 24 Sep 2023 09:51:49 +0000 (06:51 -0300)]
emacs: save undisplayer function for MIME parts
For some kinds of MIME parts (at least images), our trickery with
overlays will not work, so save the more drastic function created by
Gnus that actually deletes the part from the buffer. In an ideal world
we would return this function as (part of) a value, but here the call
stack is too complicated for anything that simple, so we stash it in
the part plist and rely on that being preserved (unlike the mm handle,
which is transient).
David Bremner [Sat, 23 Sep 2023 11:43:44 +0000 (08:43 -0300)]
Merge branch 'release'
David Bremner [Fri, 15 Sep 2023 12:50:04 +0000 (09:50 -0300)]
Pass error message from GLib ini parser to CLI
The function _notmuch_config_load_from_file is only called in two
places in open.cc. Update internal API to match the idiom in open.cc.
Adding a newline is needed for consistency with other status strings.
Based in part on a patch [1] from Eric Blake.
[1]: id:
20230906153402.101471-1-eblake@redhat.com
David Bremner [Fri, 15 Sep 2023 12:50:03 +0000 (09:50 -0300)]
test: add known broken subtest for the bad config error message
This is a bit fragile w.r.t. glib changing their error message, but it
already helped me find one formatting bug, so for now I think it's
worth it, instead of just grepping for "UTF-8".
David Bremner [Fri, 15 Sep 2023 12:50:02 +0000 (09:50 -0300)]
CLI: exit with error when load_config returns an error.
For now print a generic error message and exit with error on any
non-success code. Previously the code exited, but with exit code zero,
leading users / scripts to think the command had succeeded.
David Bremner [Fri, 15 Sep 2023 12:50:01 +0000 (09:50 -0300)]
test: add known broken test for bad utf8 in config
We should ideally print an informative error message, but at the very
least we should not exit with success.
David Bremner [Sat, 23 Sep 2023 11:16:20 +0000 (08:16 -0300)]
debian: start changelog for 0.38.1~pre0-1
David Bremner [Sat, 23 Sep 2023 11:14:21 +0000 (08:14 -0300)]
NEWS: add header for 0.38.1
Actual news items to be filled in after they are applied.