From 49a0b96486242ca4fc4d26e5b01a34e9df7a9f9f Mon Sep 17 00:00:00 2001 From: Vladimir Marek Date: Fri, 16 Aug 2013 16:38:15 +0200 Subject: [PATCH 1/1] asctime: check for standards compliance (Solaris support) Add checks to "configure" to see whether _POSIX_PTHREAD_SEMANTICS needs to be defined to get the right number of arguments in the prototypes for asctime_r(). Solaris' default implementation conforms to POSIX.1c Draft 6, rather than the final POSIX.1c spec. The standards-compliant version can be used by defining _POSIX_PTHREAD_SEMANTICS. This change also adds the file "compat/check_asctime.c", which configure uses to perform its check, and modifies compat/compat.h to define _POSIX_PTHREAD_SEMANTICS if configure detected it was needed. Signed-off-by: Vladimir Marek --- compat/check_asctime.c | 11 +++++++++++ compat/compat.h | 3 +++ configure | 22 ++++++++++++++++++++-- 3 files changed, 34 insertions(+), 2 deletions(-) create mode 100644 compat/check_asctime.c diff --git a/compat/check_asctime.c b/compat/check_asctime.c new file mode 100644 index 00000000..b0e56f0c --- /dev/null +++ b/compat/check_asctime.c @@ -0,0 +1,11 @@ +#include +#include + +int main() +{ + struct tm tm; + + (void) asctime_r (&tm, NULL); + + return (0); +} diff --git a/compat/compat.h b/compat/compat.h index c1ee0f93..0c4ac66f 100644 --- a/compat/compat.h +++ b/compat/compat.h @@ -33,6 +33,9 @@ extern "C" { #if !STD_GETPWUID #define _POSIX_PTHREAD_SEMANTICS 1 #endif +#if !STD_ASCTIME +#define _POSIX_PTHREAD_SEMANTICS 1 +#endif #if !HAVE_GETLINE #include diff --git a/configure b/configure index b5465e4c..e3aa857c 100755 --- a/configure +++ b/configure @@ -530,6 +530,17 @@ else fi rm -f compat/check_getpwuid +printf "Checking for standard version of asctime_r... " +if ${CC} -o compat/check_asctime "$srcdir"/compat/check_asctime.c > /dev/null 2>&1 +then + printf "Yes.\n" + std_asctime=1 +else + printf "No (will define _POSIX_PTHREAD_SEMANTICS to get it).\n" + std_asctime=0 +fi +rm -f compat/check_asctime + printf "int main(void){return 0;}\n" > minimal.c printf "Checking for rpath support... " @@ -697,6 +708,11 @@ HAVE_STRCASESTR = ${have_strcasestr} # to enable the standards-compliant version -- needed for Solaris) STD_GETPWUID = ${std_getpwuid} +# Whether the asctime_r function is standards-compliant +# (if not, then notmuch will #define _POSIX_PTHREAD_SEMANTICS +# to enable the standards-compliant version -- needed for Solaris) +STD_ASCTIME = ${std_asctime} + # Supported platforms (so far) are: LINUX, MACOSX, SOLARIS, FREEBSD, OPENBSD PLATFORM = ${platform} @@ -743,11 +759,13 @@ CONFIGURE_CFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE) \$(GMIME_CFLAGS) \\ \$(TALLOC_CFLAGS) -DHAVE_VALGRIND=\$(HAVE_VALGRIND) \\ \$(VALGRIND_CFLAGS) \\ -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) \\ - -DSTD_GETPWUID=\$(STD_GETPWUID) + -DSTD_GETPWUID=\$(STD_GETPWUID) \\ + -DSTD_ASCTIME=\$(STD_ASCTIME) CONFIGURE_CXXFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE) \$(GMIME_CFLAGS) \\ \$(TALLOC_CFLAGS) -DHAVE_VALGRIND=\$(HAVE_VALGRIND) \\ \$(VALGRIND_CFLAGS) \$(XAPIAN_CXXFLAGS) \\ -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) \\ - -DSTD_GETPWUID=\$(STD_GETPWUID) + -DSTD_GETPWUID=\$(STD_GETPWUID) \\ + -DSTD_ASCTIME=\$(STD_ASCTIME) CONFIGURE_LDFLAGS = \$(GMIME_LDFLAGS) \$(TALLOC_LDFLAGS) \$(XAPIAN_LDFLAGS) EOF -- 2.45.2