From 6bfa32f560b5d299ad9cdeb6bbbabf6497750c9f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jos=C3=A9=20Fonseca?= Date: Thu, 22 Mar 2012 16:26:47 +0000 Subject: [PATCH] Fix size comparisons in traceloader.cpp. This would never result in buffer in overflows, but this is more correct. --- gui/traceloader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gui/traceloader.cpp b/gui/traceloader.cpp index 7cb07f0..0e6ed47 100644 --- a/gui/traceloader.cpp +++ b/gui/traceloader.cpp @@ -104,7 +104,7 @@ int TraceLoader::numberOfFrames() const int TraceLoader::numberOfCallsInFrame(int frameIdx) const { - if (frameIdx > m_frameBookmarks.size()) { + if (frameIdx >= m_frameBookmarks.size()) { return 0; } FrameBookmarks::const_iterator itr = @@ -386,7 +386,7 @@ int TraceLoader::callInFrame(int callIdx) const { unsigned numCalls = 0; - for (int frameIdx = 0; frameIdx <= m_frameBookmarks.size(); ++frameIdx) { + for (int frameIdx = 0; frameIdx < m_frameBookmarks.size(); ++frameIdx) { const FrameBookmark &frameBookmark = m_frameBookmarks[frameIdx]; unsigned firstCall = numCalls; unsigned endCall = numCalls + frameBookmark.numberOfCalls; -- 2.45.2