From 7c7677500d560a22d18666e3e0786efa43136478 Mon Sep 17 00:00:00 2001
From: Zack Rusin <zack@kde.org>
Date: Thu, 1 Sep 2011 11:33:51 -0400
Subject: [PATCH] Fix memory usage in the on-demand-loading.

just store offsets to the first call in a frame in the loader
---
 trace_loader.cpp | 19 +++++++++++++------
 trace_loader.hpp | 11 +++++------
 trace_parser.cpp | 21 ++-------------------
 trace_parser.hpp | 14 +++++++++++---
 4 files changed, 31 insertions(+), 34 deletions(-)

diff --git a/trace_loader.cpp b/trace_loader.cpp
index 254d2cb..228553b 100644
--- a/trace_loader.cpp
+++ b/trace_loader.cpp
@@ -30,13 +30,14 @@ int Loader::numberOfFrames() const
     return m_frameOffsets.size();
 }
 
-int Loader::numberOfCallsInFrame(int frameIdx)
+int Loader::numberOfCallsInFrame(int frameIdx) const
 {
     if (frameIdx > m_frameOffsets.size()) {
         return 0;
     }
-
-    return m_frameOffsets[frameIdx].numberOfCalls;
+    FrameOffsets::const_iterator itr =
+        m_frameOffsets.find(frameIdx);
+    return itr->second.numberOfCalls;
 }
 
 bool Loader::open(const char *filename)
@@ -55,8 +56,10 @@ bool Loader::open(const char *filename)
     File::Offset startOffset;
     int numOfFrames = 0;
     int numOfCalls = 0;
+    unsigned callNum = 0;
 
     startOffset = m_parser.currentOffset();
+    callNum = m_parser.currentCallNumber();
 
     while ((call = m_parser.parse_call())) {
 
@@ -64,13 +67,15 @@ bool Loader::open(const char *filename)
 
         if (isCallAFrameMarker(call)) {
             File::Offset endOffset = m_parser.currentOffset();
-            FrameOffset frameOffset(startOffset, endOffset);
-
+            FrameOffset frameOffset(startOffset);
             frameOffset.numberOfCalls = numOfCalls;
+            frameOffset.callNumber = callNum;
+
             m_frameOffsets[numOfFrames] = frameOffset;
             ++numOfFrames;
 
             startOffset = endOffset;
+            callNum = m_parser.currentCallNumber();
             numOfCalls = 0;
         }
         //call->dump(std::cout, color);
@@ -111,8 +116,10 @@ std::vector<Trace::Call *> Loader::frame(int idx)
 {
     int numOfCalls = numberOfCallsInFrame(idx);
     if (numOfCalls) {
+        const FrameOffset &frameOffset = m_frameOffsets[idx];
         std::vector<Trace::Call*> calls(numOfCalls);
-        m_parser.setCurrentOffset(m_frameOffsets[idx].start);
+        m_parser.setCurrentOffset(frameOffset.start);
+        m_parser.setCurrentCallNumber(frameOffset.callNumber);
 
         Trace::Call *call;
         int parsedCalls = 0;
diff --git a/trace_loader.hpp b/trace_loader.hpp
index 7b746b9..2656700 100644
--- a/trace_loader.hpp
+++ b/trace_loader.hpp
@@ -30,7 +30,7 @@ public:
     void setFrameMarker(Loader::FrameMarker marker);
 
     int numberOfFrames() const;
-    int numberOfCallsInFrame(int frameIdx);
+    int numberOfCallsInFrame(int frameIdx) const;
 
     bool open(const char *filename);
     void close();
@@ -42,16 +42,14 @@ private:
         FrameOffset()
             : numberOfCalls(0)
         {}
-        FrameOffset(const File::Offset &s,
-                    const File::Offset &e)
+        FrameOffset(const File::Offset &s)
             : start(s),
-              end(e),
               numberOfCalls(0)
         {}
 
         File::Offset start;
-        File::Offset end;
         int numberOfCalls;
+        unsigned callNumber;
     };
     bool isCallAFrameMarker(const Trace::Call *call) const;
 
@@ -62,7 +60,8 @@ private:
     std::map<int, Trace::Frame*> m_frameCache;
     std::queue<Trace::Frame*> m_loadedFrames;
 
-    std::map<int, FrameOffset> m_frameOffsets;
+    typedef std::map<int, FrameOffset> FrameOffsets;
+    FrameOffsets m_frameOffsets;
 
     Trace::File *file;
 };
diff --git a/trace_parser.cpp b/trace_parser.cpp
index abed4f5..66d56a6 100644
--- a/trace_parser.cpp
+++ b/trace_parser.cpp
@@ -174,13 +174,8 @@ void Parser::parse_enter(void) {
 
     Call *call = new Call(sig);
 
-    if (hasCallBeenParsed(offset)) {
-        call->no = callNumForOffset(offset);
-    } else {
-        call->no = next_call_no++;
-        m_callNumOffsets.insert(
-                    std::pair<File::Offset, unsigned>(offset, call->no));
-    }
+
+    call->no = next_call_no++;
 
     if (parse_call_details(call)) {
         calls.push_back(call);
@@ -532,16 +527,4 @@ inline bool Parser::bitmaskWithSignature(const File::Offset &offset) const
     return m_bitmaskSigOffsets.find(offset) != m_bitmaskSigOffsets.end();
 }
 
-bool Parser::hasCallBeenParsed(const File::Offset &offset) const
-{
-    return m_callNumOffsets.find(offset) != m_callNumOffsets.end();
-}
-
-unsigned Parser::callNumForOffset(const File::Offset &offset) const
-{
-    CallNumOffsets::const_iterator itr = m_callNumOffsets.find(offset);
-    assert(itr != m_callNumOffsets.end());
-    return itr->second;
-}
-
 } /* namespace Trace */
diff --git a/trace_parser.hpp b/trace_parser.hpp
index a9f11f7..f340da0 100644
--- a/trace_parser.hpp
+++ b/trace_parser.hpp
@@ -84,7 +84,7 @@ public:
 
     bool supportsOffsets() const
     {
-        return file-supportsOffsets();
+        return file->supportsOffsets();
     }
 
     File::Offset currentOffset()
@@ -101,8 +101,16 @@ public:
     bool structWithSignature(const File::Offset &offset) const;
     bool enumWithSignature(const File::Offset &offset) const;
     bool bitmaskWithSignature(const File::Offset &offset) const;
-    bool hasCallBeenParsed(const File::Offset &offset) const;
-    unsigned callNumForOffset(const File::Offset &offset) const;
+
+    unsigned currentCallNumber() const
+    {
+        return next_call_no;
+    }
+
+    void setCurrentCallNumber(unsigned num)
+    {
+        next_call_no = num;
+    }
 
 protected:
     void parse_enter(void);
-- 
2.43.0