From: Carl Worth <cworth@cworth.org>
Date: Sat, 16 Feb 2013 01:15:53 +0000 (-0800)
Subject: trim: Don't consider a SwapBuffers call has having no side effects
X-Git-Url: https://git.cworth.org/git?p=apitrace;a=commitdiff_plain;h=6ad9d816975cf8ee94da166e95082b757ff78d49

trim: Don't consider a SwapBuffers call has having no side effects

I can't justify why I ever added this code. I can only guess that I was
trying to get qapitrace to not show frame markers for frames that had
largely been trimmed.

Anyway, the code is wrong. SwapBuffers call obviously have significant
side effects. And the effect I was trying to achieve is already well
satisified by the change in 2f0d1a3244c8953a4468759ac466b80c4965d38f
that will trim a SwapBuffers call when --trim-spec=drawing is in
force.
---

diff --git a/cli/trace_analyzer.cpp b/cli/trace_analyzer.cpp
index 730dab9..803c81c 100644
--- a/cli/trace_analyzer.cpp
+++ b/cli/trace_analyzer.cpp
@@ -271,12 +271,6 @@ TraceAnalyzer::callHasNoSideEffects(trace::Call *call, const char *name)
         return true;
     }
 
-    /* Similarly, swap-buffers calls don't have interesting side effects. */
-    if (call->flags & trace::CALL_FLAG_SWAP_RENDERTARGET &&
-        call->flags & trace::CALL_FLAG_END_FRAME) {
-        return true;
-    }
-
     /* Not known as a no-side-effect call. Return false for more analysis. */
     return false;
 }