]> git.cworth.org Git - empires-server/commit
empires: Return immediately from reveal_next if we aren't in the REVEAL state
authorCarl Worth <cworth@cworth.org>
Sun, 17 May 2020 19:28:35 +0000 (12:28 -0700)
committerCarl Worth <cworth@cworth.org>
Sun, 17 May 2020 19:28:35 +0000 (12:28 -0700)
commit38e0c09faeefc252754b48ea9d7b2b3c93a69fe5
tree0dbd3352cd627098725f4ffaad90f77c1078ef80
parenta44b9dd5ed5bc7a221655bddbf07dcb498cac90d
empires: Return immediately from reveal_next if we aren't in the REVEAL state

I think this fix came about after Kevin did some testing by mashing on
all of the host buttons as fast as possible.

It's definitely a correct fix as far as it's true we shouldn't be
revealing anything if we're not in the REVEAL state. But I think we're
due for a better audit of what's happening to various pieces of state
on state transitions, (such as, shouldn't the interval timer get
cleared before we _leave_ the REVEAL state).
empires.js