]> git.cworth.org Git - empires-server/commit
Start the judging_idle timer whenever a judgment is received
authorCarl Worth <cworth@cworth.org>
Fri, 26 Jun 2020 14:45:10 +0000 (07:45 -0700)
committerCarl Worth <cworth@cworth.org>
Fri, 26 Jun 2020 14:45:31 +0000 (07:45 -0700)
commit60c56d50f8ada21f0dc9eea0bf4485cc7fcf1375
tree90f54712d4166db441d571104d3f2897211f4931
parentaf0746e6f592e8cc5940465e7688aac33afea4de
Start the judging_idle timer whenever a judgment is received

Previously, we were starting the judging_idle timer only when a user
reported they were in the process of judging. This caused a bug in the
following scenario:

  * No players group any words

  * Majority of players submit the word groups unchanged

  * Minority of players drop from the game

  * The PHASE_IDLE_TIMEOUT passes

At this point, the game is supposed to consider the judging phase as
idle, but it wasn't doing this because the idle timer never got
started, (because no players actually grouped any words).

This bug came up in some (admittedly artificial) manual
testing. There's no chane to the test suite here because the current
test suite isn't yet exercising the timing related aspects of the
game, (the phase idle timeouts, etc.).
empathy.js