]> git.cworth.org Git - empires-server/commitdiff
Add new failing test case: Non-player can terminate judging
authorCarl Worth <cworth@cworth.org>
Sun, 28 Jun 2020 00:49:00 +0000 (17:49 -0700)
committerCarl Worth <cworth@cworth.org>
Sun, 28 Jun 2020 00:49:28 +0000 (17:49 -0700)
The code that is intending to check whether all answering players have
completed judging is currently broken. It is only checking whether the
number of players that have judged is as large as the number of
players that have answered.

This is the wrong logic in the case where a player who didn't answer
joins the game late and submits judging results, which is exactly what
we do in the new test case here.

This test case currently fails, so a fix of the bug described above
will cause it to start passing.

test

diff --git a/test b/test
index fcb556c5baa4e11c1ed1ab3eeaf216bb54c3f1da..646cdcabc0654af15ecbe90b1d5870c7e9846b29 100755 (executable)
--- a/test
+++ b/test
@@ -856,6 +856,16 @@ result=$(echo $(empathy_scores alice))
 test "$result" = "null"
 TEST_END
 
+TEST "Submit word groups from a non-answering player"
+result=$(empathy_judged dale $prompt_id '[]')
+test "$result" = '{"valid":true}'
+TEST_END
+
+TEST "Scoring still hasn't started"
+result=$(echo $(empathy_scores alice))
+test "$result" = "null"
+TEST_END
+
 TEST "Submit word groups from last answering player"
 result=$(empathy_judged charlie $prompt_id '[]')
 test "$result" = '{"valid":true}'