From 1c0d86cea49a79e94c884ffd4c811fe696db534b Mon Sep 17 00:00:00 2001 From: Carl Worth Date: Fri, 12 Jun 2020 09:56:35 -0700 Subject: [PATCH] test: Empathy: Extend test to submit judging results with proper capitalization In commit abea9915939bd7f5b6e70f12d724f19dc6694ec9 we extended the test suite to cover the case of players submitting words with mixed capitalization and we ensured that the server didn't send out any duplicate words for judging, (that it ignored case when determining which words were unique). However, in that commit we still had the players returning the results of their judging in all lowercase. This is not a good test since actual clients will return words exactly as they received them. Here we improve the test by submitting judging results with the same capitalization that the server used when sending out the ambiguities. And we also expect that same capitalization to appear in the final word list. However, this test currently fails in the final word list _and_ also fails in the scoring. So this test is exposing a bug that currently exists in the server. --- test | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test b/test index 8732e93..27469ee 100755 --- a/test +++ b/test @@ -537,17 +537,17 @@ test "$result" = '"Grains of Sand" "people" "sand" "sands" "sun" "SunLight" "Sun TEST_END TEST "Submit word groups from alice" -result=$(empathy_judging $alice $prompt_id '[["sun","sunlight","sunshine"],["sand","sands","grains of sand"],["water","wafer"]]') +result=$(empathy_judging $alice $prompt_id '[["sun","SunLight","SunShine"],["sand","sands","Grains of Sand"],["water","wafer"]]') test "$result" = '{"valid":true}' TEST_END TEST "Submit word groups from bob" -result=$(empathy_judging $bob $prompt_id '[["sands","grains of sand"],["water","wafer"]]') +result=$(empathy_judging $bob $prompt_id '[["sands","Grains of Sand"],["water","wafer"]]') test "$result" = '{"valid":true}' TEST_END TEST "Submit word groups from charlie" -result=$(empathy_judging $charlie $prompt_id '[["sunlight","sunshine"],["sand","grains of sand"]]') +result=$(empathy_judging $charlie $prompt_id '[["SunLight","SunShine"],["sand","Grains of Sand"]]') test "$result" = '{"valid":true}' TEST_END @@ -574,7 +574,7 @@ empathy_words_submitted() TEST "Verify final list of words submitted" # echo here is to strip newlines result=$(echo $(empathy_words_submitted $alice)) -test "$result" = '"grains of sand/sand/sands" "sunlight/sunshine" "wafer/water" "people" "sun" "towels"' +test "$result" = '"Grains of Sand/sand/sands" "SunLight/SunShine" "wafer/water" "people" "sun" "towels"' TEST_END TEST_REPORT -- 2.43.0