From: Carl Worth <cworth@cworth.org>
Date: Mon, 24 Jun 2013 22:49:44 +0000 (-0700)
Subject: eglwrap: Add comment describing why we don't lookup into libGLESv2.so
X-Git-Url: https://git.cworth.org/git?p=fips;a=commitdiff_plain;h=7ca2f1e135d95263282b7cb01dff7e301f2146cf

eglwrap: Add comment describing why we don't lookup into libGLESv2.so

A user recently asked me why we didn't perform lookups in
libGLESv2.so, (instead of just libEGL.so). I actually made the mistake
of writing code to do that before I realized the answer.

Adding the answer in a comment here should help me avoid making that
mistake again.
---

diff --git a/eglwrap.c b/eglwrap.c
index 43b07ba..8317334 100644
--- a/eglwrap.c
+++ b/eglwrap.c
@@ -48,6 +48,15 @@
 } while (0);
 
 
+/* Note: We only need to perform a lookup in libEGL.so.1, (not
+ * libGLESv2.so.2). This is because the functions we wrap, (currently
+ * wglSwapBufers, eglGetProcAddress, and eglMakeCurrent), exist only
+ * in libEGL.so.1.
+ *
+ * If we *do* later add wrappers for functions that lib in
+ * libGLESv2.so.2 then those might more naturally live in a file named
+ * gleswrap.c or so.
+ */
 static void *
 eglwrap_lookup (char *name)
 {