empathy: Don't allow a prompt with 0 items

[lmno-server] / empathy.js

diff --git a/empathy.js b/empathy.js
index 7710892819235061d0710b14386c2cc1d8786877..c1d150f354d9bb4207f985b7da65540d4caa8ccd 100644 (file)
--- a/empathy.js
+++ b/empathy.js
@@ -19,7 +19,7 @@ const PHASE_MINIMUM_TIME = 30;
  *
  * Specified in seconds
  */
-const PHASE_IDLE_TIMEOUT = 30;
+const PHASE_IDLE_TIMEOUT = 15;
 
 class Empathy extends Game {
   constructor(id) {
@@ -76,12 +76,13 @@ class Empathy extends Game {
 
     /* Now that we're done with the active prompt, we remove it from
      * the list of prompts and also remove any prompts that received
-     * no votes. This keeps the list of prompts clean.
+     * more negative votes than positive. This keeps the list of
+     * prompts clean.
      */
     const active_id = this.state.active_prompt.id;
     this.state.prompts =
       this.state.prompts.filter(
-        p => p.id !== active_id && p.votes.length > 0
+        p => p.id !== active_id && p.votes.length >= p.votes_against.length
       );
 
     this.state.active_prompt = null;
@@ -114,11 +115,19 @@ class Empathy extends Game {
   }
 
   add_prompt(items, prompt_string) {
-    if (items > MAX_PROMPT_ITEMS)
+    if (items > MAX_PROMPT_ITEMS) {
       return {
         valid: false,
         message: `Maximum number of items is ${MAX_PROMPT_ITEMS}`
       };
+    }
+
+    if (items < 1) {
+      return {
+        valid: false,
+        message: "Category must require at least one item"
+      };
+    }
 
     const prompt = new Prompt(this.next_prompt_id, items, prompt_string);
     this.next_prompt_id++;
@@ -597,10 +606,14 @@ class Prompt {
   }
 
   toggle_vote_against(player_name) {
-    if (this.votes_against.find(v => v === player_name))
+    if (this.votes_against.find(v => v === player_name)) {
       this.votes_against = this.votes_against.filter(v => v !== player_name);
-    else
+    } else {
       this.votes_against.push(player_name);
+      /* When voting against, we also remove any vote _for_ the same
+       * prompt. */
+      this.votes = this.votes.filter(v => v !== player_name);
+    }
   }
 }