]> git.cworth.org Git - lmno-server/commitdiff
Fix bug described in the previous commit
authorCarl Worth <cworth@cworth.org>
Sat, 27 Jun 2020 14:31:52 +0000 (07:31 -0700)
committerCarl Worth <cworth@cworth.org>
Sat, 27 Jun 2020 14:32:24 +0000 (07:32 -0700)
With this fix, we now advance to the scoring phase as soon as the same
number of people have completed judging as submitted answers in the
first place. (That is, don't wait for a registered player that didn't
participate in the answering phase to now participate in the judging
phase.)

With this fix, the failing test added in the previous commit now
passes, so the test suite is now fully passing.

empathy.js

index 5e59dd20ef4fb710e242850fd1dc34fa1f06d218..35d5fc7e737726f7426ff58d2c7950ae77fccc6a 100644 (file)
@@ -611,9 +611,9 @@ router.post('/judged/:prompt_id([0-9]+)', (request, response) => {
                                      request.body.word_groups);
   response.json(result);
 
-  /* If every registered player has judged, then there's no need to
-   * wait for anything else. */
-  if (game.state.players_judged.length >= game.players.length)
+  /* If every player who answered has also judged, then there's no
+   * need to wait for anything else. */
+  if (game.state.players_judged.length >= game.state.players_answered.length)
     game.compute_scores();
 });