From: Carl Worth <cworth@cworth.org>
Date: Sun, 28 Jun 2020 21:54:26 +0000 (-0700)
Subject: Change prompt-retirement to require more negative than votes to retire
X-Git-Url: https://git.cworth.org/git?p=lmno-server;a=commitdiff_plain;h=8e236d4023f974dbe5e9ed0c9c8796134b33e046

Change prompt-retirement to require more negative than votes to retire

Or, as expressed here, more (or equal) positive votes than negative in
order to preserve a prompt.

However the logic is worded, the point is that the old rule "Retire
any prompt with no votes" had a serious flaw: When someone submitted a
new category _just_ before a round started, nobody would get a chance
to vote for it, and then it would be dropped before anyone would see
it on the next round.

Now, instead, just like most everything else in empathy, the retiring
of an undesired category is now determined by a vote.
---

diff --git a/empathy.js b/empathy.js
index 7710892..50d18d5 100644
--- a/empathy.js
+++ b/empathy.js
@@ -76,12 +76,13 @@ class Empathy extends Game {
 
     /* Now that we're done with the active prompt, we remove it from
      * the list of prompts and also remove any prompts that received
-     * no votes. This keeps the list of prompts clean.
+     * more negative votes than positive. This keeps the list of
+     * prompts clean.
      */
     const active_id = this.state.active_prompt.id;
     this.state.prompts =
       this.state.prompts.filter(
-        p => p.id !== active_id && p.votes.length > 0
+        p => p.id !== active_id && p.votes.length >= p.votes_against.length
       );
 
     this.state.active_prompt = null;