From 422dafa274b3e9858621f1973c98e313fc0213c8 Mon Sep 17 00:00:00 2001 From: Carl Worth Date: Sat, 27 Jun 2020 07:31:52 -0700 Subject: [PATCH] Fix bug described in the previous commit With this fix, we now advance to the scoring phase as soon as the same number of people have completed judging as submitted answers in the first place. (That is, don't wait for a registered player that didn't participate in the answering phase to now participate in the judging phase.) With this fix, the failing test added in the previous commit now passes, so the test suite is now fully passing. --- empathy.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/empathy.js b/empathy.js index 5e59dd2..35d5fc7 100644 --- a/empathy.js +++ b/empathy.js @@ -611,9 +611,9 @@ router.post('/judged/:prompt_id([0-9]+)', (request, response) => { request.body.word_groups); response.json(result); - /* If every registered player has judged, then there's no need to - * wait for anything else. */ - if (game.state.players_judged.length >= game.players.length) + /* If every player who answered has also judged, then there's no + * need to wait for anything else. */ + if (game.state.players_judged.length >= game.state.players_answered.length) game.compute_scores(); }); -- 2.43.0