Fix the key for some list items

[lmno.games] / empathy / empathy.jsx

diff --git a/empathy/empathy.jsx b/empathy/empathy.jsx
index e887b1b8b9b1af33ddc76aa751613f66a2253205..2867dab55c1873f97f79650f2774879c80ff8c11 100644 (file)
--- a/empathy/empathy.jsx
+++ b/empathy/empathy.jsx
@@ -363,6 +363,45 @@ class CategoryRequest extends React.PureComponent {
   }
 }
 
+const PromptOption = React.memo(props => {
+
+  const prompt = props.prompt;
+
+  if (prompt.votes_against.find(v => v === props.player.name))
+    return false;
+
+  return (
+    <button
+      className="vote-button"
+      key={prompt.id}
+      onClick={() => fetch_post_json(`vote/${prompt.id}`) }
+    >
+      <span
+        className="hide-button"
+        onClick={(event) => {
+          event.stopPropagation();
+          fetch_post_json(`vote_against/${prompt.id}`);
+        }}
+      >
+        &times;
+      </span>
+      {prompt.prompt}
+      <div className="vote-choices">
+        {prompt.votes.map(v => {
+          return (
+            <div
+              key={v}
+              className="vote-choice"
+            >
+              {v}
+            </div>
+          );
+        })}
+      </div>
+    </button>
+  );
+});
+
 const PromptOptions = React.memo(props => {
 
   if (props.prompts.length === 0)
@@ -375,29 +414,7 @@ const PromptOptions = React.memo(props => {
         Select any categories below that you'd like to play.
         You can choose as many as you'd like.
       </p>
-      {props.prompts.map(p => {
-        return (
-          <button
-            className="vote-button"
-            key={p.id}
-            onClick={() => fetch_post_json(`vote/${p.id}`) }
-          >
-            {p.prompt}
-            <div className="vote-choices">
-              {p.votes.map(v => {
-                return (
-                  <div
-                    key={v}
-                    className="vote-choice"
-                  >
-                    {v}
-                  </div>
-                );
-              })}
-            </div>
-          </button>
-        );
-      })}
+    {props.prompts.map(p => <PromptOption prompt={p} player={props.player} />)}
     </div>
   );
 });
@@ -572,26 +589,33 @@ class Ambiguities extends React.PureComponent {
     let still_waiting = null;
     const judging_players = Object.keys(this.props.players_judging);
     if (judging_players.length) {
-      still_waiting = [
-        <p>
-          Still waiting for the following player
-          {judging_players.length > 1 ? 's' : '' }
-          :
-        </p>,
-        <ul>
-          {judging_players.map(player => {
-            return (
-              <li
-                key={player}
-              >
-                {player}
-                {this.props.players_judging[player] ?
-                 <span className="typing"/> : null }
-              </li>
-            );
-          })}
-        </ul>
-      ];
+      still_waiting = (
+        <div>
+          <p>
+            Still waiting for the following player
+            {judging_players.length > 1 ? 's' : '' }
+            :
+          </p>
+          <ul>
+            {judging_players.map(player => {
+              return (
+                <li
+                  key={player}
+                >
+                  {player}{' '}
+                  <span className=
+                  {this.props.players_judging[player].active ?
+                   "typing active"
+                   :
+                   "typing idle"}>
+                    <span>{'.'}</span><span>{'.'}</span><span>{'.'}</span>
+                  </span>
+                </li>
+              );
+            })}
+          </ul>
+        </div>
+      );
     }
 
     if (this.props.players_judged.has(this.props.player.name)) {
@@ -745,26 +769,33 @@ class ActivePrompt extends React.PureComponent {
     let still_waiting = null;
     const answering_players = Object.keys(this.props.players_answering);;
     if (answering_players.length) {
-      still_waiting = [
-        <p>
-          Still waiting for the following player
-          {answering_players.length > 1 ? 's' : ''}
-          :
-        </p>,
-        <ul>
-           {answering_players.map(player => {
-             return (
-               <li
-                 key={player}
-               >
-                 {player}
-                 {this.props.players_answering[player] ?
-                  <span className="typing"/> : null }
-               </li>
-             );
-           })}
-        </ul>
-      ];
+      still_waiting = (
+        <div>
+          <p>
+            Still waiting for the following player
+            {answering_players.length > 1 ? 's' : ''}
+            :
+          </p>
+          <ul>
+            {answering_players.map(player => {
+              return (
+                <li
+                  key={player}
+                >
+                  {player}{' '}
+                  <span className=
+                  {this.props.players_answering[player].active ?
+                   "typing active"
+                   :
+                   "typing idle"}>
+                    <span>{'.'}</span><span>{'.'}</span><span>{'.'}</span>
+                  </span>
+                </li>
+              );
+            })}
+          </ul>
+        </div>
+      );
     }
 
     if (this.props.players_answered.has(this.props.player.name)) {
@@ -950,12 +981,29 @@ class Game extends React.PureComponent {
   }
 
   set_player_answering(player) {
+    /* Set the player as actively answering now. */
     this.setState({
       players_answering: {
         ...this.state.players_answering,
         [player]: {active: true}
       }
     });
+    /* And arrange to have them marked idle very shortly.
+     *
+     * Note: This timeout is intentionally very, very short. We only
+     * need it long enough that the browser has latched onto the state
+     * change to "active" above. We actually use a CSS transition
+     * delay to control the user-perceptible length of time after
+     * which an active player appears inactive.
+     */
+    setTimeout(() => {
+      this.setState({
+        players_answering: {
+          ...this.state.players_answering,
+          [player]: {active: false}
+        }
+      });
+    }, 100);
   }
 
   set_answering_idle(value) {
@@ -1015,12 +1063,30 @@ class Game extends React.PureComponent {
   }
 
   set_player_judging(player) {
+    /* Set the player as actively judging now. */
     this.setState({
       players_judging: {
         ...this.state.players_judging,
         [player]: {active: true}
       }
     });
+    /* And arrange to have them marked idle very shortly.
+     *
+     * Note: This timeout is intentionally very, very short. We only
+     * need it long enough that the browser has latched onto the state
+     * change to "active" above. We actually use a CSS transition
+     * delay to control the user-perceptible length of time after
+     * which an active player appears inactive.
+     */
+    setTimeout(() => {
+      this.setState({
+        players_judging: {
+          ...this.state.players_judging,
+          [player]: {active: false}
+        }
+      });
+    }, 100);
+
   }
 
   set_judging_idle(value) {
@@ -1089,8 +1155,8 @@ class Game extends React.PureComponent {
           <ul>
             {state.scores.scores.map(score => {
               return (
-                <li key={score.player}>
-                  {score.players.join("/")}: {score.score}
+                <li key={score.players[0]}>
+                  {score.players.join("/")}: {score.score} {perfect}
                 </li>
               );
             })}
@@ -1172,6 +1238,7 @@ class Game extends React.PureComponent {
       <PromptOptions
         key="prompts"
         prompts={state.prompts}
+        player={state.player_info}
       />,
       <LetsPlay
         key="lets-play"