X-Git-Url: https://git.cworth.org/git?p=lmno.games;a=blobdiff_plain;f=empathy%2Fempathy.jsx;h=39889f7d8d7d16e4aba10f4385d8564931696a57;hp=bc70a85f0df820b34c552de473df8d971352f1b4;hb=78536d0d2b714d5a88dcb67124c2de963c2e316d;hpb=0dfce9dfcf903be9bb4bd27a3b9121c81ac4cfa4 diff --git a/empathy/empathy.jsx b/empathy/empathy.jsx index bc70a85..39889f7 100644 --- a/empathy/empathy.jsx +++ b/empathy/empathy.jsx @@ -283,7 +283,7 @@ class CategoryRequest extends React.PureComponent { const match = category.match(/[0-9]+/); if (match) { const num_items = parseInt(match[0], 10); - if (num_items <= MAX_PROMPT_ITEMS) + if (num_items > 0 && num_items <= MAX_PROMPT_ITEMS) category_input.setCustomValidity(""); } } @@ -311,6 +311,12 @@ class CategoryRequest extends React.PureComponent { return; } + if (num_items < 1) { + category_input.setCustomValidity("Category must require at least one item."); + form.reportValidity(); + return; + } + const response = await fetch_post_json("prompts", { items: num_items, prompt: category @@ -427,14 +433,34 @@ const PromptOptions = React.memo(props => { const LetsPlay = React.memo(props => { - const quorum = Math.round((props.num_players + 1) / 2); + const quorum = Math.max(0, props.num_players - props.prompts.length); const max_votes = props.prompts.reduce( (max_so_far, v) => Math.max(max_so_far, v.votes.length), 0); - if (max_votes < quorum) - return null; + if (max_votes < quorum) { + let text = `Before we play, we should collect a bit + more information about what category would + be interesting for this group. So, either + type a new category option above, or else`; + if (props.prompts.length) { + if (props.prompts.length > 1) + text += " vote on some of the categories below."; + else + text += " vote on the category below."; + } else { + text += " wait for others to submit, and then vote on them below."; + } - const candidates = props.prompts.filter(p => p.votes.length >= quorum); + return ( +
+

+ {text} +

+
+ ); + } + + const candidates = props.prompts.filter(p => p.votes.length >= max_votes); const index = Math.floor(Math.random() * candidates.length); const winner = candidates[index]; @@ -502,8 +528,11 @@ class Ambiguities extends React.PureComponent { const response = await fetch_post_json( `judged/${this.props.prompt.id}`,{ - word_groups: this.state.word_sets.map(set => Array.from(set)), - kudos: this.state.starred ? Array.from(this.state.starred) : null + word_groups: this.state.word_sets.map( + set => ({ + words: Array.from(set), + kudos: this.state.starred === set ? true : false + })) } ); @@ -595,7 +624,7 @@ class Ambiguities extends React.PureComponent { className="vote-button" onClick={() => fetch_post_json(`end-judging/${this.props.prompt.id}`) } > - Move On + Move On Without Their Input
{[...this.props.votes].map(v => { return ( @@ -783,29 +812,6 @@ class ActivePrompt extends React.PureComponent { } render() { - let move_on_button = null; - if (this.props.idle) { - move_on_button =( - - ); - } let still_waiting = null; const answering_players = Object.keys(this.props.players_answering);; @@ -839,6 +845,32 @@ class ActivePrompt extends React.PureComponent { ); } + let move_on_button = null; + if (this.props.idle) { + move_on_button =( + + ); + } + if (this.props.players_answered.has(this.props.player.name)) { return (
@@ -1206,12 +1238,22 @@ class Game extends React.PureComponent {