X-Git-Url: https://git.cworth.org/git?p=lmno.games;a=blobdiff_plain;f=empathy%2Fempathy.jsx;h=82bb5ff681989470aa2a78e10d9f7eedc5f42d51;hp=60540c03b8246d84fcab3b5c9dc7507f500c10b4;hb=9e08b1b85cc467336129e22bc0ece6dfe74d204e;hpb=123507982e9643a1cf2d747fbd556fc3856bfa49 diff --git a/empathy/empathy.jsx b/empathy/empathy.jsx index 60540c0..82bb5ff 100644 --- a/empathy/empathy.jsx +++ b/empathy/empathy.jsx @@ -1,3 +1,5 @@ +const MAX_PROMPT_ITEMS = 20; + function undisplay(element) { element.style.display="none"; } @@ -55,13 +57,31 @@ events.addEventListener("player-update", event => { events.addEventListener("game-state", event => { const state = JSON.parse(event.data); + window.game.reset_game_state(); + window.game.set_prompts(state.prompts); window.game.set_active_prompt(state.active_prompt); - window.game.set_scores(state.scores); + window.game.set_players_answered(state.players_answered); + + window.game.set_players_answering(state.players_answering); + + window.game.set_answering_idle(state.answering_idle); + + window.game.set_end_answers(state.end_answers); window.game.set_ambiguities(state.ambiguities); + + window.game.set_players_judged(state.players_judged); + + window.game.set_players_judging(state.players_judging); + + window.game.set_judging_idle(state.judging_idle); + + window.game.set_end_judging(state.end_judging); + + window.game.set_scores(state.scores); }); events.addEventListener("prompt", event => { @@ -76,10 +96,34 @@ events.addEventListener("start", event => { window.game.set_active_prompt(prompt); }); -events.addEventListener("answered", event => { - const players_answered = JSON.parse(event.data); +events.addEventListener("player-answered", event => { + const player = JSON.parse(event.data); + + window.game.set_player_answered(player); +}); + +events.addEventListener("player-answering", event => { + const player = JSON.parse(event.data); - window.game.set_players_answered(players_answered); + window.game.set_player_answering(player); +}); + +events.addEventListener("answering-idle", event => { + const value = JSON.parse(event.data); + + window.game.set_answering_idle(value); +}); + +events.addEventListener("vote-end-answers", event => { + const player = JSON.parse(event.data); + + window.game.set_player_vote_end_answers(player); +}); + +events.addEventListener("unvote-end-answers", event => { + const player = JSON.parse(event.data); + + window.game.set_player_unvote_end_answers(player); }); events.addEventListener("ambiguities", event => { @@ -88,10 +132,34 @@ events.addEventListener("ambiguities", event => { window.game.set_ambiguities(ambiguities); }); -events.addEventListener("judged", event => { - const players_judged = JSON.parse(event.data); +events.addEventListener("player-judged", event => { + const player = JSON.parse(event.data); - window.game.set_players_judged(players_judged); + window.game.set_player_judged(player); +}); + +events.addEventListener("player-judging", event => { + const player = JSON.parse(event.data); + + window.game.set_player_judging(player); +}); + +events.addEventListener("judging-idle", event => { + const value = JSON.parse(event.data); + + window.game.set_judging_idle(value); +}); + +events.addEventListener("vote-end-judging", event => { + const player = JSON.parse(event.data); + + window.game.set_player_vote_end_judging(player); +}); + +events.addEventListener("unvote-end-judging", event => { + const player = JSON.parse(event.data); + + window.game.set_player_unvote_end_judging(player); }); events.addEventListener("scores", event => { @@ -137,16 +205,18 @@ const PlayerInfo = React.memo(props => { if (! props.player.id) return null; + const sorted_players = [props.player, ...props.other_players].sort((a,b) => { + return b.score - a.score; + }); + return (
Players: - {props.player.name} - {props.player.score > 0 ? ` (${props.player.score})` : ""} - {props.other_players.map(other => ( - - {", "} - {other.name} - {other.score > 0 ? ` (${other.score})` : ""} + {sorted_players.map(player => ( + + {player.name} + {player.score > 0 ? ` (${player.score})` : ""} + {" "} ))}
@@ -185,11 +255,15 @@ class CategoryRequest extends React.PureComponent { const category_input = this.category.current; const category = category_input.value; - if (/[0-9]/.test(category)) - category_input.setCustomValidity(""); + const match = category.match(/[0-9]+/); + if (match) { + const num_items = parseInt(match[0], 10); + if (num_items <= MAX_PROMPT_ITEMS) + category_input.setCustomValidity(""); + } } - handle_submit(event) { + async handle_submit(event) { const form = event.currentTarget; const category_input = this.category.current; const category = category_input.value; @@ -204,11 +278,29 @@ class CategoryRequest extends React.PureComponent { return; } - fetch_post_json("prompts", { - items: parseInt(match[0], 10), + const num_items = parseInt(match[0], 10); + + if (num_items > MAX_PROMPT_ITEMS) { + category_input.setCustomValidity(`Maximum number of items is ${MAX_PROMPT_ITEMS}`); + form.reportValidity(); + return; + } + + const response = await fetch_post_json("prompts", { + items: num_items, prompt: category }); + if (response.status === 200) { + const result = await response.json(); + if (! result.valid) { + add_message("danger", result.message); + return; + } + } else { + add_message("danger", "An error occurred submitting your category"); + } + form.reset(); } @@ -287,10 +379,6 @@ const PromptOptions = React.memo(props => { const LetsPlay = React.memo(props => { - function handle_click(prompt_id) { - fetch_post_json - } - const quorum = Math.round((props.num_players + 1) / 2); const max_votes = props.prompts.reduce( (max_so_far, v) => Math.max(max_so_far, v.votes.length), 0); @@ -324,16 +412,32 @@ class Ambiguities extends React.PureComponent { constructor(props) { super(props); + const word_sets = props.words.map(word => { + const set = new Set(); + set.add(word); + return set; + }); + this.state = { - word_groups: props.words.map(word => [word]), - submitted: false, + word_sets: word_sets, selected: null }; + + this.submitted = false; + this.judging_sent_recently = false; } async handle_submit() { - const response = await fetch_post_json(`judging/${this.props.prompt.id}`, - this.state.word_groups); + + /* Don't submit a second time. */ + if (this.submitted) + return; + + const response = await fetch_post_json( + `judged/${this.props.prompt.id}`,{ + word_groups: this.state.word_sets.map(set => Array.from(set)) + } + ); if (response.status === 200) { const result = await response.json(); @@ -342,47 +446,70 @@ class Ambiguities extends React.PureComponent { return; } } else { - add_message("danger", "An error occurred submitting your answers"); + add_message("danger", "An error occurred submitting the results of your judging"); return; } - this.setState({ - submitted: true - }); + this.submitted = true; } handle_click(word) { + + /* Let the server know we are doing some judging, (but rate limit + * this so we don't send a "judging" notification more frquently + * than necessary. + */ + if (! this.judging_sent_recently) { + fetch_post_json(`judging/${this.props.prompt.id}`); + this.judging_sent_recently = true; + setTimeout(() => { this.judging_sent_recently = false; }, 1000); + } + if (this.state.selected == word) { /* Second click on same word removes the word from the group. */ - const new_groups = this.state.word_groups.filter( - group => (! group.includes(this.state.selected)) || (group.length > 1)).map( - group => { - return group.filter(w => w !== this.state.selected); - } - ); + const idx = this.state.word_sets.findIndex(s => s.has(word)); + const set = this.state.word_sets[idx]; + if (set.size === 1) { + /* When the word is already alone, there's nothing to do but + * to un-select it. */ + this.setState({ + selected: null + }); + return; + } + + const new_set = new Set([...set].filter(w => w !== word)); this.setState({ selected: null, - word_groups: [...new_groups, [word]] + word_sets: [...this.state.word_sets.slice(0, idx), + new_set, + new Set().add(word), + ...this.state.word_sets.slice(idx+1)] }); } else if (this.state.selected) { /* Click of a second word groups the two together. */ - const new_groups = this.state.word_groups.filter( - group => (! group.includes(word)) || (group.length > 1)).map( - group => { - if (group.includes(this.state.selected)) { - if (! group.includes(word)) - return [...group, word]; - else - return group; - } else { - return group.filter(w => w !== word); - } - } - ); - this.setState({ - selected: null, - word_groups: new_groups - }); + const idx1 = this.state.word_sets.findIndex(s => s.has(this.state.selected)); + const idx2 = this.state.word_sets.findIndex(s => s.has(word)); + const set1 = this.state.word_sets[idx1]; + const set2 = this.state.word_sets[idx2]; + const new_set = new Set([...set2, ...set1]); + if (idx1 < idx2) { + this.setState({ + selected: null, + word_sets: [...this.state.word_sets.slice(0, idx1), + ...this.state.word_sets.slice(idx1 + 1, idx2), + new_set, + ...this.state.word_sets.slice(idx2 + 1)] + }); + } else { + this.setState({ + selected: null, + word_sets: [...this.state.word_sets.slice(0, idx2), + new_set, + ...this.state.word_sets.slice(idx2 + 1, idx1), + ...this.state.word_sets.slice(idx1 + 1)] + }); + } } else { /* First click of a word selects it. */ this.setState({ @@ -392,16 +519,60 @@ class Ambiguities extends React.PureComponent { } render() { - if (this.state.submitted) + let move_on_button = null; + + if (this.props.idle) { + move_on_button = ( + + ); + } + + if (this.props.players_judged.has(this.props.player.name)) { return (
-

{this.props.players_judged}/ - {this.props.players_total} players have responded

+

Submission received

- Please wait for the rest of the players to complete judging. + The following players have completed judging: + {[...this.props.players_judged].join(', ')}

+

+ Still waiting for the following players: +

+ + {move_on_button} +
); + } const btn_class = "ambiguity-button"; const btn_selected_class = btn_class + " selected"; @@ -415,24 +586,24 @@ class Ambiguities extends React.PureComponent { what goes around comes around, so it's best to be generous when judging.

- {this.state.word_groups.map(word_group => { + {this.state.word_sets.map(set => { return (
- {word_group.map(word => { - return ( - - ); - })} + {word} + + ); + })}
); })} @@ -455,12 +626,30 @@ class ActivePrompt extends React.PureComponent { super(props); const items = props.prompt.items; - this.state = { - submitted: false - }; + this.submitted = false; this.answers = [...Array(items)].map(() => React.createRef()); + this.answering_sent_recently = false; + this.handle_submit = this.handle_submit.bind(this); + this.handle_change = this.handle_change.bind(this); + } + + handle_change(event) { + /* We don't care (or even look) at what the player is typing at + * this point. We simply want to be informed that the player _is_ + * typing so that we can tell the server (which will tell other + * players) that there is activity here. + */ + + /* Rate limit so that we don't send an "answering" notification + * more frequently than necessary. + */ + if (! this.answering_sent_recently) { + fetch_post_json(`answering/${this.props.prompt.id}`); + this.answering_sent_recently = true; + setTimeout(() => { this.answering_sent_recently = false; }, 1000); + } } async handle_submit(event) { @@ -469,6 +658,10 @@ class ActivePrompt extends React.PureComponent { /* Prevent the default page-changing form-submission behavior. */ event.preventDefault(); + /* And don't submit a second time. */ + if (this.submitted) + return; + const response = await fetch_post_json(`answer/${this.props.prompt.id}`, { answers: this.answers.map(r => r.current.value) }); @@ -485,22 +678,63 @@ class ActivePrompt extends React.PureComponent { /* Everything worked. Server is happy with our answers. */ form.reset(); - this.setState({ - submitted: true - }); + this.submitted = true; } render() { - if (this.state.submitted) + let move_on_button = null; + if (this.props.idle) { + move_on_button =( + + ); + } + + if (this.props.players_answered.has(this.props.player.name)) { return (
-

{this.props.players_answered}/ - {this.props.players_total} players have responded

+

Submission received

+

+ The following players have submitted their answers: + {[...this.props.players_answered].join(', ')} +

- Please wait for the rest of the players to submit their answers. + Still waiting for the following players:

+ + {move_on_button} +
); + } return (
@@ -522,6 +756,7 @@ class ActivePrompt extends React.PureComponent { name={`answer_${i}`} required autoComplete="off" + onChange={this.handle_change} ref={this.answers[i]} />
@@ -551,9 +786,16 @@ class Game extends React.PureComponent { other_players: [], prompts: [], active_prompt: null, - players_answered: 0, + players_answered: new Set(), + players_answering: {}, + answering_idle: false, + end_answers_votes: new Set(), ambiguities: null, - players_judged: 0 + players_judged: new Set(), + players_judging: {}, + judging_idle: false, + end_judging_votes: new Set(), + scores: null }; } @@ -582,6 +824,23 @@ class Game extends React.PureComponent { }); } + reset_game_state() { + this.setState({ + prompts: [], + active_prompt: null, + players_answered: new Set(), + players_answering: {}, + answering_idle: false, + end_answers_votes: new Set(), + ambiguities: null, + players_judged: new Set(), + players_judging: {}, + judging_idle: false, + end_judging_votes: new Set(), + scores: null + }); + } + set_prompts(prompts) { this.setState({ prompts: prompts @@ -607,9 +866,62 @@ class Game extends React.PureComponent { }); } - set_players_answered(players_answered) { + set_players_answered(players) { this.setState({ - players_answered: players_answered + players_answered: new Set(players) + }); + } + + set_player_answered(player) { + const new_players_answering = {...this.state.players_answering}; + delete new_players_answering[player]; + + this.setState({ + players_answered: new Set([...this.state.players_answered, player]), + players_answering: new_players_answering + }); + } + + set_players_answering(players) { + const players_answering = {}; + for (let player of players) { + players_answering[player] = {active: false}; + } + this.setState({ + players_answering: players_answering + }); + } + + set_player_answering(player) { + this.setState({ + players_answering: { + ...this.state.players_answering, + [player]: {active: true} + } + }); + } + + set_answering_idle(value) { + this.setState({ + answering_idle: value + }); + } + + set_end_answers(players) { + this.setState({ + end_answers_votes: new Set(players) + }); + } + + set_player_vote_end_answers(player) { + this.setState({ + end_answers_votes: new Set([...this.state.end_answers_votes, player]) + }); + } + + set_player_unvote_end_answers(player) { + this.setState({ + end_answers_votes: new Set([...this.state.end_answers_votes].filter(p => p !== player)) }); } @@ -619,9 +931,63 @@ class Game extends React.PureComponent { }); } - set_players_judged(players_judged) { + set_players_judged(players) { + this.setState({ + players_judged: new Set(players) + }); + } + + set_player_judged(player) { + const new_players_judging = {...this.state.players_judging}; + delete new_players_judging[player]; + + this.setState({ + players_judged: new Set([...this.state.players_judged, player]), + players_judging: new_players_judging + }); + } + + set_players_judging(players) { + const players_judging = {}; + for (let player of players) { + players_judging[player] = {active: false}; + } + this.setState({ + players_judging: players_judging + }); + } + + set_player_judging(player) { + this.setState({ + players_judging: { + ...this.state.players_judging, + [player]: {active: true} + } + }); + } + + set_judging_idle(value) { + console.log("Setting judging idle to " + value); + this.setState({ + judging_idle: value + }); + } + + set_end_judging(players) { + this.setState({ + end_judging_votes: new Set(players) + }); + } + + set_player_vote_end_judging(player) { + this.setState({ + end_judging_votes: new Set([...this.state.end_judging_votes, player]) + }); + } + + set_player_unvote_end_judging(player) { this.setState({ - players_judged: players_judged + end_judging_votes: new Set([...this.state.end_judging_votes].filter(p => p !== player)) }); } @@ -653,12 +1019,7 @@ class Game extends React.PureComponent { {state.scores.words.map(word => { return (
  • - {word.word}: - {word.players.map(p => { - return ( - {p}{" "} - ); - })} + {`${word.word}: ${word.players.join(', ')}`}
  • ); })} @@ -677,16 +1038,22 @@ class Game extends React.PureComponent { return ; } if (state.active_prompt) { return ; }