From: Carl Worth Date: Mon, 29 Jun 2020 15:32:51 +0000 (-0700) Subject: Reword the Move On button when we're not waiting for anyone specific X-Git-Url: https://git.cworth.org/git?p=lmno.games;a=commitdiff_plain;h=c37a82b05938a9013d0ffd6a4f6d28165393f9d8;ds=sidebyside Reword the Move On button when we're not waiting for anyone specific This case arises when there are additional players still connected to the game, but that haven't even started typing any answers. In this case, the view looks like this: Submission received The following players have submitted their answers: In this case, wording of "Move On Without Their Answers" suggests the exact opposite, (as if "their" is referring to the submitted players rather than those not listed on this page). The new wording in this case, "Move On Without Anyone Else" makes it more clear what the behavior is. --- diff --git a/empathy/empathy.jsx b/empathy/empathy.jsx index 2511250..53d7763 100644 --- a/empathy/empathy.jsx +++ b/empathy/empathy.jsx @@ -829,7 +829,9 @@ class ActivePrompt extends React.PureComponent { className="vote-button" onClick={() => fetch_post_json(`end-answers/${this.props.prompt.id}`) } > - Move On Without Their Answers + {answering_players.length ? + "Move On Without Their Answers" : + "Move On Without Anyone Else"}
{[...this.props.votes].map(v => { return (