X-Git-Url: https://git.cworth.org/git?p=notmuch-wiki;a=blobdiff_plain;f=contributing.mdwn;h=a5bbfb3dd6e390ef8fb945d437f27ed6d7ea3fcc;hp=263f181e1df3f78218d13cd6c484a155cda371c0;hb=HEAD;hpb=2150fa4cca9ce334d009f028f256326035bb0baa diff --git a/contributing.mdwn b/contributing.mdwn index 263f181..a5bbfb3 100644 --- a/contributing.mdwn +++ b/contributing.mdwn @@ -19,7 +19,7 @@ help out as needed. The Notmuch source code is maintained in [git](http://git-scm.com/). Get the source code using: - git clone git://notmuchmail.org/git/notmuch + git clone https://git.notmuchmail.org/git/notmuch This guide assumes a working knowledge of git. There are plenty of resources available on git, such as [Pro Git](http://git-scm.com/book) and the git man @@ -112,11 +112,17 @@ Notmuch source. If you modify or add new features to the Notmuch Emacs UI, you should update the Emacs documentation. +If you add a new keybinding, update `devel/emacs-keybindings.org`. As +much as possible, try to be consistent between modes. + ## Update NEWS If you make user visible changes, you should add an entry to the [`NEWS`](https://git.notmuchmail.org/git/notmuch/blob/HEAD:/NEWS) file. +In practice adding NEWS items can be done later during the release +process, but then you typically get a one line mention, if at all. + ## Update command-line completion If you modify or add new features to the Notmuch command-line tools, it @@ -128,7 +134,7 @@ afterwards. ## Subscribe to the Notmuch mailing list While strictly not required, it is advisable to subscribe to the -[Notmuch mailing list](https://notmuchmail.org/mailman/listinfo/notmuch) +[Notmuch mailing list](https://nmbug.notmuchmail.org/list/) before submitting patches. ## Send your patches to the mailing list @@ -158,7 +164,7 @@ If you are submitting a non-trivial set of patches, or if there's any extra information you want to share that is not really part of the commit messages, it is advisable to write a cover letter to give an overview of your work. See the -[Notmuch mailing list archives](https://notmuchmail.org/pipermail/notmuch/) +[Notmuch mailing list archives](https://nmbug.notmuchmail.org/nmweb/) for examples. Use the `--cover-letter` option of `git format-patch`, or `--compose` option of `git send-email`. @@ -180,7 +186,7 @@ usually by one or two developers, depending on the impact of the changes. You are expected to follow up on the review comments you receive, either by discussing the comments and the code, or modifying your patches. Again, see the [Notmuch mailing list -archives](https://notmuchmail.org/pipermail/notmuch/) for examples. +archives](https://nmbug.notmuchmail.org/nmweb) for examples. ## Send another round addressing review comments @@ -231,6 +237,6 @@ changes or obsoletes information on the site. It's a wiki; see the ## Join the Notmuch IRC channel Patch review happens on the Notmuch mailing list, but there is plenty of -discussion going on in the freenode #notmuch IRC channel. See -[freenode.net/irc_servers.shtml](http://freenode.net/irc_servers.shtml) +discussion going on in the libera #notmuch IRC channel. See +[libera.chat/guides/connect](https://libera.chat/guides/connect) for information how to get there.