From: David Bremner <david@tethera.net>
Date: Thu, 8 May 2014 11:57:07 +0000 (+0900)
Subject: notmuch-dump: use fsync instead of fdatasync
X-Git-Tag: 0.18.1~22
X-Git-Url: https://git.cworth.org/git?p=notmuch;a=commitdiff_plain;h=f3ee655b493c7e57621226a98abc9e9db5d0cb27

notmuch-dump: use fsync instead of fdatasync

Since the file size will have changed, there is no performance benefit
to calling fdatasync.  Somewhat surprisingly, using fdatasync
apparently causes portability problems on FreeBSD.
---

diff --git a/notmuch-dump.c b/notmuch-dump.c
index 2849eaba..887a2082 100644
--- a/notmuch-dump.c
+++ b/notmuch-dump.c
@@ -169,7 +169,7 @@ notmuch_database_dump (notmuch_database_t *notmuch,
     }
 
     if (output_file_name) {
-	ret = fdatasync (outfd);
+	ret = fsync (outfd);
 	if (ret) {
 	    fprintf (stderr, "Error syncing %s to disk: %s\n",
 		     name_for_error, strerror (errno));