X-Git-Url: https://git.cworth.org/git?p=ttt;a=blobdiff_plain;f=src%2Fttt-client.c;h=508aa88e91ecffba87e9c7e63a3caaa92db521ea;hp=9d44945e506664678854fab51c41fa3fd04e870d;hb=f8bdcd97af8d0dcee79ab692fffb83dba5a5498a;hpb=907321c065fb1383e800f0794981df91d4327f57

diff --git a/src/ttt-client.c b/src/ttt-client.c
index 9d44945..508aa88 100644
--- a/src/ttt-client.c
+++ b/src/ttt-client.c
@@ -21,9 +21,11 @@
 
 #include "ttt-client.h"
 
+#include "ttt-error.h"
+#include "ttt-lex.h"
 #include "ttt-server.h"
 #include "ttt-socket.h"
-#include "ttt-error.h"
+#include "ttt-token.h"
 
 struct _ttt_client {
     pthread_mutex_t mutex;
@@ -31,39 +33,85 @@ struct _ttt_client {
 
     ttt_server_t *server;
     int socket;
+    yyscan_t scanner;
 
-    int id;
+    char *name;
+
+    char **request_strings;
+    int num_request_strings;
+};
 
-    char buf[TTT_CLIENT_BUF_SIZE];
-    char *buf_head;
-    char *buf_tail;
+typedef ttt_error_t (*ttt_command_func_t) (ttt_client_t *client,
+					   char **args,
+					   int num_args);
 
-    char *request;
-    int request_size;
-    int request_len;
+static ttt_error_t
+_ttt_client_execute_helo (ttt_client_t *client,
+			  char         **args,
+			  int          num_args);
+
+typedef struct _ttt_command_description {
+    const char *command;
+    int args_min;
+    int args_max;
+    ttt_command_func_t execute;
+} ttt_command_description_t;
+
+ttt_command_description_t command_descriptions[] = {
+    {"HELO", 1, 1, _ttt_client_execute_helo}
 };
 
+static ttt_error_t
+_ttt_client_execute_helo (ttt_client_t *client,
+			  char         **args,
+			  int          num_args)
+{
+    ttt_error_t error;
+    char *response;
+
+    if (num_args == 1)
+	ttt_client_set_name (client, args[0]);
+
+    error = ttt_server_register_client (client->server, client);
+    if (error)
+	return error;
+
+    xasprintf (&response, "HELO %s %s %s\n", client->name,
+	       ttt_server_get_host (client->server),
+	       ttt_server_get_port (client->server));
+
+    ttt_client_send (client, response);
+
+    free (response);
+
+    return TTT_ERROR_NONE;
+}
+
+#define ARRAY_SIZE(arr) (sizeof(arr)/sizeof(arr[0]))
+
+static void
+_free_request (ttt_client_t *client);
+
 static void
 _ttt_client_init (ttt_client_t	*client,
 		  ttt_server_t	*server,
 		  int		 socket)
 {
+    FILE *file;
+
     pthread_mutex_init (&client->mutex, NULL);
 
     client->server = server;
     client->socket = socket;
 
-    client->buf_head = client->buf;
-    client->buf_tail = client->buf;
+    file = xfdopen (socket, "r");
+    yylex_init(&client->scanner);
+    yyset_in (file, client->scanner);
 
-    client->request = NULL;
-    client->request_size = 0;
-    client->request_len = 0;
+    client->request_strings = NULL;
+    client->num_request_strings = 0;
 
-    /* XXX: Probably want to register only as the result of the HELO
-       command.  Not only will that match the protocol correctly, but
-       it will also eliminate a race condition here. */
-    client->id = ttt_server_register_client (server, client);
+    client->name = NULL;
 }
 
 static void
@@ -73,99 +121,94 @@ _ttt_client_fini (ttt_client_t *client)
 
     ttt_server_unregister_client (client->server, client);
 
+    free (client->name);
+    client->name = NULL;
+
+    yylex_destroy (client->scanner);
     shutdown (client->socket, SHUT_RDWR);
 
-    free (client->request);
+    _free_request (client);
 
     pthread_mutex_unlock (&client->mutex);
 
     pthread_mutex_destroy (&client->mutex);
 }
 
+/* XXX: The memory management for the request strings is pretty cheesy. */
 static void
 _append_to_request (ttt_client_t	*client,
-		    const char		*buf,
-		    int			 size)
+		    const char		*string)
 {
-    int size_needed = client->request_len + size;
-
-    if (size_needed > client->request_size) {
-	if (client->request_size == 0) {
-	    client->request_size = size_needed;
-	} else {
-	    while (size_needed > client->request_size)
-		client->request_size *= 2;
-	}
-
-	client->request = xrealloc (client->request, client->request_size);
-    }
-
-    memcpy (client->request + client->request_len,
-	    buf, size);
+    client->num_request_strings++;
+    client->request_strings =
+	xrealloc (client->request_strings,
+		  client->num_request_strings * sizeof (char *));
 
-    client->request_len += size;
+    client->request_strings[client->num_request_strings - 1] = xstrdup (string);
 }
 
-static ttt_status_t
-_read_into_request_until (ttt_client_t *client, char delimeter)
+static void
+_free_request (ttt_client_t *client)
 {
-    ttt_bool_t found_delimeter = FALSE;
-    int bytes_read;
-    char *s;
+    int i;
 
-    client->request_len = 0;
+    for (i = 0; i < client->num_request_strings; i++)
+	free (client->request_strings[i]);
 
-    while (1) {
+    free (client->request_strings);
 
-	if (client->buf_tail >= client->buf_head) {
-	    bytes_read = xread (client->socket,
-				client->buf,
-				TTT_CLIENT_BUF_SIZE);
-	    if (bytes_read == 0)
-		return TTT_STATUS_EOF;
-	    client->buf_head = client->buf;
-	    client->buf_tail = client->buf_head + bytes_read;
-	}
-
-	for (s = client->buf_head; s < client->buf_tail; s++) {
-	    if (*s == delimeter) {
-		found_delimeter = TRUE;
-		s++;
-		break;
-	    }
-	}
-
-	_append_to_request (client,
-			    client->buf_head,
-			    s - client->buf_head);
-	client->buf_head = s;
-
-	if (found_delimeter)
-	    return TTT_STATUS_SUCCESS;
-    }
+    client->request_strings = NULL;
+    client->num_request_strings = 0;
 }
 
 static ttt_status_t
 _read_request (ttt_client_t *client)
 {
-    ttt_status_t status;
-    static const char null_terminator = '\0';
+    ttt_token_t token;
+
+    _free_request (client);
 
-    status = _read_into_request_until (client, '\n');
-    if (status)
-	return status;
+    while (1) {
+	token = yylex (client->scanner);
+	/* Yes, EOF in two different enums is pretty ugly. */
+	if (token == TTT_TOKEN_EOF)
+	    return TTT_STATUS_EOF;
+
+	if (token == TTT_TOKEN_NEWLINE) {
+	    if (client->num_request_strings)
+		return TTT_STATUS_SUCCESS;
+	    else
+		continue;
+	}
 
-    _append_to_request (client, &null_terminator, 1);
+	assert (token == TTT_TOKEN_STRING);
 
-    return TTT_STATUS_SUCCESS;
+	_append_to_request (client, yyget_text (client->scanner));
+    }
 }
 
 static ttt_error_t
 _execute_request (ttt_client_t *client)
 {
-    ttt_server_broadcast (client->server, client->request);
+    int i;
 
-    return TTT_ERROR_NONE;
+    char *command = client->request_strings[0];
+    int num_args = client->num_request_strings-1;
+    ttt_command_description_t *desc;
+
+    for (i=0; i < strlen (command); i++)
+	command[i] = toupper (command[i]);
+
+    for (i=0; i < ARRAY_SIZE(command_descriptions); i++) {
+	desc = &command_descriptions[i];
+	if (strcmp(command, desc->command) == 0) {
+	    if ((num_args < desc->args_min) || (num_args > desc->args_max))
+		return TTT_ERROR_SYNTAX;
+	    return (desc->execute) (client, &client->request_strings[1], num_args);
+	    }
+	}
+
+    return TTT_ERROR_COMMAND;
 }
 
 static void *
@@ -227,8 +270,16 @@ ttt_client_send (ttt_client_t *client, const char *message)
 }
 
 /* Exported: See ttt-client.h for documentation. */
-int
-ttt_client_get_id (ttt_client_t *client)
+const char*
+ttt_client_get_name (ttt_client_t *client)
+{
+    return client->name;
+}
+
+/* Exported: See ttt-client.h for documentation. */
+void
+ttt_client_set_name (ttt_client_t *client, const char *name)
 {
-    return client->id;
+    free (client->name);
+    client->name = xstrdup (name);
 }