From 2dd1171d23caf8fcc739541bfad22d3805a094a9 Mon Sep 17 00:00:00 2001 From: Carl Worth Date: Sat, 9 Jan 2021 07:45:37 -0800 Subject: [PATCH] Use best-practice <@user_id> to mention a user in Slack This way Slack expands this as a link to the user's full name. --- TODO | 4 ---- turbot/interaction.py | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/TODO b/TODO index 9f9b903..bc8385d 100644 --- a/TODO +++ b/TODO @@ -15,10 +15,6 @@ Recently-proposed ideas (not yet prioritized) (since the implicit report from settting the abbreviated topic won't have the whole message). -• In messages (like from /solved) don't use a raw user_name value from - the request, but instead some tagged version of a user ID (which - Slack will render as a display name). - • Allow a hunt (and perhaps a round) to have multiple URLs • Provide an "Archive channel" button in the channel when outputting diff --git a/turbot/interaction.py b/turbot/interaction.py index 1f5d11f..ec64706 100644 --- a/turbot/interaction.py +++ b/turbot/interaction.py @@ -967,7 +967,7 @@ def solved(turb, body, args): The args string should be a confirmed solution.""" channel_id = body['channel_id'][0] - user_name = body['user_name'][0] + user_id = body['user_id'][0] old_puzzle = puzzle_for_channel(turb, channel_id) @@ -991,7 +991,7 @@ def solved(turb, body, args): # Report the solution to the puzzle's channel slack_send_message( turb.slack_client, channel_id, - "Puzzle mark solved by {}: `{}`".format(user_name, args)) + "Puzzle mark solved by <@{}>: `{}`".format(user_id, args)) # Also report the solution to the hunt channel hunt = find_hunt_for_hunt_id(turb, puzzle['hunt_id']) -- 2.43.0