From 4f902f0849ca59389d2e9f08bc015e3eb9c63164 Mon Sep 17 00:00:00 2001 From: Carl Worth Date: Mon, 11 Jan 2021 09:54:57 -0800 Subject: [PATCH] Drop use of response_url in button handlers Some buttons appear in a context, (like the app's "Home" view), where there is no response_url, (we can't generate a message there). So we can't rely on this. And we don't need to anyway, we can use the string in the reteurn value to get an error message out to the user. This commit should fix a bunch of broken puzzle edits button in the Turbot "home" view. --- turbot/interaction.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/turbot/interaction.py b/turbot/interaction.py index 392574d..e020389 100644 --- a/turbot/interaction.py +++ b/turbot/interaction.py @@ -146,7 +146,6 @@ def edit_puzzle_button(turb, payload): """Handler for the action of user pressing an edit_puzzle button""" action_id = payload['actions'][0]['action_id'] - response_url = payload['response_url'] trigger_id = payload['trigger_id'] (hunt_id, sort_key) = action_id.split('-', 1) @@ -154,9 +153,6 @@ def edit_puzzle_button(turb, payload): puzzle = find_puzzle_for_sort_key(turb, hunt_id, sort_key) if not puzzle: - requests.post(response_url, - json = {"text": "Error: Puzzle not found!"}, - headers = {"Content-type": "application/json"}) return bot_reply("Error: Puzzle not found.") return edit_puzzle(turb, puzzle, trigger_id) @@ -387,15 +383,11 @@ def edit_hunt_button(turb, payload): """Handler for the action of user pressing an edit_hunt button""" hunt_id = payload['actions'][0]['action_id'] - response_url = payload['response_url'] trigger_id = payload['trigger_id'] hunt = find_hunt_for_hunt_id(hunt_id) if not hunt: - requests.post(response_url, - json = {"text": "Error: Hunt not found!"}, - headers = {"Content-type": "application/json"}) return bot_reply("Error: Hunt not found.") return edit_hunt(turb, hunt, trigger_id) -- 2.43.0