tictactoe: Simplify code by not reusing the expression "this.state"

[empires-server] / tictactoe.js

diff --git a/tictactoe.js b/tictactoe.js
index f9198432826376426d5d5a527e145bfe71f9e172..98564799c438e57460c96a1a1feaac243cd11318 100644 (file)
--- a/tictactoe.js
+++ b/tictactoe.js
@@ -7,7 +7,7 @@ class TicTacToe extends Game {
     this.state = {
       moves: [],
       board: Array(9).fill(""),
-      next_player: "X",
+      team_to_play: "X",
     };
     this.teams = ["X", "O"];
   }
@@ -15,34 +15,28 @@ class TicTacToe extends Game {
   /* Returns true if move was legal and added, false otherwise. */
   add_move(player, square) {
 
-    /* Cannot move if you are not on a team. */
-    if (player.team === "")
-    {
-      return { legal: false,
-               message: "You must be on a team to take a turn" };
-    }
+    const state = this.state;
+    const result = super.add_move(player, square);
 
-    /* Cannot move if it's not this player's team's turn. */
-    if (player.team !== this.state.next_player)
-    {
-      return { legal: false,
-               message: "It's not your turn to move" };
-    }
+    /* If the generic Game class can reject this move, then we don't
+     * need to look at it any further. */
+    if (! result.legal)
+      return result;
 
     /* Cannot move to an occupied square. */
-    if (this.state.board[square])
+    if (state.board[square])
     {
       return { legal: false,
                message: "Square is already occupied" };
     }
 
-    this.state.board[square] = this.state.next_player;
-    this.state.moves.push(square);
+    state.board[square] = state.team_to_play;
+    state.moves.push(square);
 
-    if (this.state.next_player === "X")
-      this.state.next_player = "O";
+    if (state.team_to_play === "X")
+      state.team_to_play = "O";
     else
-      this.state.next_player = "X";
+      state.team_to_play = "X";
 
     return { legal: true };
   }