]> git.cworth.org Git - empires-server/commitdiff
tictactoe: Simplify code by not reusing the expression "this.state"
authorCarl Worth <cworth@cworth.org>
Fri, 5 Jun 2020 23:14:04 +0000 (16:14 -0700)
committerCarl Worth <cworth@cworth.org>
Fri, 5 Jun 2020 23:14:04 +0000 (16:14 -0700)
Instead, just call this once with "const state = this.state" and then
just use "state" for all subsequent uses.

tictactoe.js

index d123c5718f01b5fb93280447d003f91e4eac1e1a..98564799c438e57460c96a1a1feaac243cd11318 100644 (file)
@@ -15,6 +15,7 @@ class TicTacToe extends Game {
   /* Returns true if move was legal and added, false otherwise. */
   add_move(player, square) {
 
+    const state = this.state;
     const result = super.add_move(player, square);
 
     /* If the generic Game class can reject this move, then we don't
@@ -23,19 +24,19 @@ class TicTacToe extends Game {
       return result;
 
     /* Cannot move to an occupied square. */
-    if (this.state.board[square])
+    if (state.board[square])
     {
       return { legal: false,
                message: "Square is already occupied" };
     }
 
-    this.state.board[square] = this.state.team_to_play;
-    this.state.moves.push(square);
+    state.board[square] = state.team_to_play;
+    state.moves.push(square);
 
-    if (this.state.team_to_play === "X")
-      this.state.team_to_play = "O";
+    if (state.team_to_play === "X")
+      state.team_to_play = "O";
     else
-      this.state.team_to_play = "X";
+      state.team_to_play = "X";
 
     return { legal: true };
   }