Move some slack utility code into turbot/slack.py

[turbot] / turbot_lambda / turbot_lambda.py

diff --git a/turbot_lambda/turbot_lambda.py b/turbot_lambda/turbot_lambda.py
index ba8d06db20c66e4ada2d8a0dabc1279ecea4dd4d..ece58d62f577ee3553926115e79f146adcd3dbd6 100644 (file)
--- a/turbot_lambda/turbot_lambda.py
+++ b/turbot_lambda/turbot_lambda.py
@@ -1,17 +1,21 @@
 from urllib.parse import parse_qs
-from turbot.rot import rot
-from turbot import views
 from slack import WebClient
 import boto3
 import requests
-import hashlib
-import hmac
 import json
+import os
+from turbot.rot import rot
+import turbot.views
+import turbot.actions
 
 ssm = boto3.client('ssm')
 
 response = ssm.get_parameter(Name='SLACK_SIGNING_SECRET', WithDecryption=True)
-slack_signing_secret = bytes(response['Parameter']['Value'], 'utf-8')
+slack_signing_secret = response['Parameter']['Value']
+os.environ['SLACK_SIGNING_SECRET'] = slack_signing_secret
+
+# Note: Late import here to have the environment variable above available
+from turbot.slack import slack_is_valid_request # noqa
 
 response = ssm.get_parameter(Name='SLACK_BOT_TOKEN', WithDecryption=True)
 slack_bot_token = response['Parameter']['Value']
@@ -31,24 +35,6 @@ def error(message):
         'body': ''
     }
 
-def slack_is_valid_request(slack_signature, timestamp, body):
-    """Returns True if the timestamp and body correspond to signature.
-
-    This implements the Slack signature verification using the slack
-    signing secret (obtained via an SSM parameter in code above)."""
-
-    content = "v0:{}:{}".format(timestamp,body).encode('utf-8')
-
-    signature = 'v0=' + hmac.new(slack_signing_secret,
-                                 content,
-                                 hashlib.sha256).hexdigest()
-
-    if hmac.compare_digest(signature, slack_signature):
-        return True
-    else:
-        print("Bad signature: {} != {}".format(signature, slack_signature))
-        return False
-
 def turbot_lambda(event, context):
     """Top-level entry point for our lambda function.
 
@@ -116,7 +102,7 @@ def event_callback_handler(body):
 
 def app_home_opened_handler(body):
     user_id = body['event']['user']
-    view = views.home(user_id, body)
+    view = turbot.views.home(user_id, body)
     slack_client.views_publish(user_id=user_id, view=view)
     return "OK"
 
@@ -145,7 +131,31 @@ def turbot_interactive(payload):
     a shortcut or some other interactive element that our app has made
     available to the user."""
 
-    print("In turbot_interactive, payload is: {}".format(str(payload)))
+    type = payload['type']
+
+    if type == 'block_actions':
+        return turbot_block_action(payload)
+    return error("Unrecognized interactive type: {}".format(type))
+
+def turbot_block_action(payload):
+    """Handler for Slack interactive block actions
+
+    Specifically, those that have a payload type of 'block_actions'"""
+
+    actions = payload['actions']
+
+    if len(actions) != 1:
+        return error("No support for multiple actions ({}) in a single request"
+                     .format(len(actions)))
+
+    action = actions[0]
+
+    atype = action['type']
+    avalue = action['value']
+
+    if atype == 'button' and avalue == 'new_hunt':
+        return turbot.actions.new_hunt(payload)
+    return error("Unknown action of type/value: {}/{}".format(atype, avalue))
 
 def turbot_slash_command(body):
     """Implementation for Slack slash commands.