summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
3474159)
I keep learning that the less logic there is in JSX, the better.
if (! props.player.id)
return null;
if (! props.player.id)
return null;
- const sorted_players = [props.player, ...props.other_players].sort((a,b) => {
+ const all_players = [props.player, ...props.other_players];
+
+ const sorted_players = all_players.sort((a,b) => {
return b.score - a.score;
});
return b.score - a.score;
});
+ const names_and_scores = sorted_players.map(player => {
+ if (player.score)
+ return `${player.name} (${player.score})`;
+ else
+ return player.name;
+ }).join(', ');
+
return (
<div className="player-info">
<span className="players-header">Players: </span>
return (
<div className="player-info">
<span className="players-header">Players: </span>
- {sorted_players.map(player => (
- <span key={player.id}>
- {player.name}
- {player.score > 0 ? ` (${player.score})` : ""}
- {" "}
- </span>
- ))}
+ <span>{names_and_scores}</span>