Tone down some MSVC warnings.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f817701e1f8e8ef6798ac41487e8e11124d0ea01..033d9fe5359079eb211266aa2e73bf1a91edf5cc 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -92,13 +92,15 @@ if (MSVC)
     add_definitions (-D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS)
     add_definitions (-D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS)
     add_definitions (-W4)
+    # XXX: it's safer to use ssize_t everywhere instead of disabling warning
+    add_definitions (-wd4018) # signed/unsigned mismatch
     add_definitions (-wd4063) # not a valid value for switch of enum
+    add_definitions (-wd4100) # unreferenced formal parameter
     add_definitions (-wd4127) # conditional expression is constant
     add_definitions (-wd4244) # conversion from 'type1' to 'type2', possible loss of data
     add_definitions (-wd4505) # unreferenced local function has been removed
+    add_definitions (-wd4512) # assignment operator could not be generated
     add_definitions (-wd4800) # forcing value to bool 'true' or 'false' (performance warning)
-    # XXX: it's safer to use ssize_t everywhere instead of disabling warning
-    add_definitions (-wd4018) # signed/unsigned mismatch
     
     # Use static runtime
     # http://www.cmake.org/Wiki/CMake_FAQ#How_can_I_build_my_MSVC_application_with_a_static_runtime.3F

diff --git a/common/os_binary.hpp b/common/os_binary.hpp
index 876bdb6c880e1d42dabf18873a4e1708306d1bc9..a231c7090c61959c5dfd294502ccc100fefbf9a8 100644 (file)
--- a/common/os_binary.hpp
+++ b/common/os_binary.hpp
@@ -49,6 +49,7 @@ void setBinaryMode(FILE *fp) {
     fflush(fp);
     int mode = _setmode(_fileno(fp), _O_BINARY);
     assert(mode != -1);
+    (void)mode;
 #else
     (void)fp;
 #endif