os_posix: Print complete, attempted command line when execute() fails

Previously, only argv[0] was printed which did not provide much
information to the user about why the command might have
failed. Printing the entire command line allows the user to more
easily investigate the problem.

Signed-off-by: José Fonseca <jose.r.fonseca@gmail.com>

diff --git a/common/os_posix.cpp b/common/os_posix.cpp
index 7d39d8ada5e0ffafc0f730bcdd3e913744f734d2..0d93b31bcafa6e56604fa639a7656d20128835ca 100644 (file)
--- a/common/os_posix.cpp
+++ b/common/os_posix.cpp
@@ -134,7 +134,11 @@ int execute(char * const * args)
     if (pid == 0) {
         // child
         execvp(args[0], args);
-        fprintf(stderr, "error: failed to execute %s\n", args[0]);
+        fprintf(stderr, "error: failed to execute:");
+        for (unsigned i = 0; args[i]; ++i) {
+            fprintf(stderr, " %s", args[i]);
+        }
+        fprintf(stderr, "\n");
         exit(-1);
     } else {
         // parent